<div dir="ltr">Hey Mikko,<div><br></div><div>This changes the 'semantics' of the code and is a bug. Could I suggest rather using 0U to silence your compiler... ;)</div><div><br></div><div>Cheers</div><div>Jason</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 3, 2016 at 9:25 AM, Mikko Lehto <span dir="ltr"><<a href="mailto:mslehto@iki.fi" target="_blank">mslehto@iki.fi</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Module: kamailio<br>
Branch: master<br>
Commit: 94b4c25640c0f486c578a9e0670dad0aa5dda0c1<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/94b4c25640c0f486c578a9e0670dad0aa5dda0c1" rel="noreferrer" target="_blank">https://github.com/kamailio/kamailio/commit/94b4c25640c0f486c578a9e0670dad0aa5dda0c1</a><br>
<br>
Author: Mikko Lehto <<a href="mailto:mslehto@iki.fi">mslehto@iki.fi</a>><br>
Committer: Mikko Lehto <<a href="mailto:mslehto@iki.fi">mslehto@iki.fi</a>><br>
Date: 2016-05-25T13:49:21+03:00<br>
<br>
modules/ims_qos modules/ims_registrar_scscf: fix comparison of unsigned expression<br>
<br>
---<br>
<br>
Modified: modules/ims_qos/rx_avp.c<br>
Modified: modules/ims_registrar_scscf/save.c<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/94b4c25640c0f486c578a9e0670dad0aa5dda0c1.diff" rel="noreferrer" target="_blank">https://github.com/kamailio/kamailio/commit/94b4c25640c0f486c578a9e0670dad0aa5dda0c1.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/94b4c25640c0f486c578a9e0670dad0aa5dda0c1.patch" rel="noreferrer" target="_blank">https://github.com/kamailio/kamailio/commit/94b4c25640c0f486c578a9e0670dad0aa5dda0c1.patch</a><br>
<br>
---<br>
<br>
diff --git a/modules/ims_qos/rx_avp.c b/modules/ims_qos/rx_avp.c<br>
index 657716c..124855c 100644<br>
--- a/modules/ims_qos/rx_avp.c<br>
+++ b/modules/ims_qos/rx_avp.c<br>
@@ -489,7 +489,7 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, s<br>
// Get A=RS-bandwidth from SDP-Reply:<br>
bandwidth = sdp_b_value(rpl_raw_payload, "RS");<br>
LM_DBG("Answer: Got bandwidth %i from b=RS-Line\n", bandwidth);<br>
- if (bandwidth >= 0) {<br>
+ if (bandwidth > 0) {<br>
// Add AVP<br>
set_4bytes(x,bandwidth);<br>
rs_bw = cdpb.AAACreateAVP(AVP_EPC_RS_Bandwidth,<br>
@@ -501,7 +501,7 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, s<br>
// Get A=RS-bandwidth from SDP-Reply:<br>
bandwidth = sdp_b_value(rpl_raw_payload, "RR");<br>
LM_DBG("Answer: Got bandwidth %i from b=RR-Line\n", bandwidth);<br>
- if (bandwidth >= 0) {<br>
+ if (bandwidth > 0) {<br>
// Add AVP<br>
set_4bytes(x,bandwidth);<br>
rr_bw = cdpb.AAACreateAVP(AVP_EPC_RR_Bandwidth,<br>
diff --git a/modules/ims_registrar_scscf/save.c b/modules/ims_registrar_scscf/save.c<br>
index 501eaa7..47dcf80 100644<br>
--- a/modules/ims_registrar_scscf/save.c<br>
+++ b/modules/ims_registrar_scscf/save.c<br>
@@ -111,7 +111,7 @@ static inline int randomize_expires(int expires, int range) {<br>
static inline int calc_contact_expires(contact_t *c, unsigned int expires_hdr, int sos_reg) {<br>
unsigned int r;<br>
<br>
- if (expires_hdr >= 0)<br>
+ if (expires_hdr > 0)<br>
r = expires_hdr;<br>
else {<br>
r = (sos_reg > 0) ? default_registrar_cfg.em_default_expires : default_registrar_cfg.default_expires;<br>
<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" rel="noreferrer" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><table style="width:450pt" cellpadding="0" cellspacing="0" border="0" width="600"><tbody><tr><td style="padding:0cm" valign="top"><p></p></td></tr></tbody></table><table style="font-family:monospace" cellpadding="0" cellspacing="0" border="0" width="320px"><tbody><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><b>Jason Penton</b></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><b>Senior Manager: Applications and Services</b></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><b>Smile Communications Pty (Ltd)</b></td></tr><tr><td><table cellpadding="0" cellspacing="0" width="100%"><tbody><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px" width="27%"><b>Voice:<br><br>Mobile:</b></td><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px" width="73%"><span>+234 (0) 702 000 000 7</span><br><br>+27 (0) 83 283 7000</td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><b>Skype:</b></td><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px">jason.barry.penton</td></tr></tbody></table></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a href="mailto:name.surname@smilecoms.com" style="font-family:Arial;color:rgb(117,179,67);text-decoration:none" target="_blank">jason.penton@smilecoms.com</a></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a href="http://www.smilecoms.com/" style="font-family:Arial;color:rgb(117,179,67)" target="_blank">www.smilecoms.com</a><br><img src="http://196.33.227.129/~smlcoms/sigs/pty/images/smile_signature_07_09.jpg" height="144" width="420"><br></td></tr></tbody></table></div><br></div></div></div></div></div></div>
</div>
<br>
<span><font color="#888888"><pre>This email is subject to the disclaimer of Smile Communications at <a href="http://www.smilecoms.com/home/email-disclaimer/" target="_blank">http://www.smilecoms.com/home/<WBR>email-disclaimer/</a><a href="http://www.smilecoms.com/disclaimer" target="_blank"></a></pre></font></span>