<p><a href="https://github.com/sipidronov" class="user-mention">@sipidronov</a> good catch, indeed. It should be user_agent.s and only set if the user_agent.len>0. Even in the current form works because .s is the firs field in the str structure, that is not safe for future.</p>

<p>I also think the variable and parameter should be prefixed with http_, as those related to the http query of utils are (e.g., timeout), to be more clear that it refers to the http functionality from the module.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/670#issuecomment-225897805">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AF36ZaY9FSWo7vSYADXbabwaJ6ruyl_Cks5qLrnVgaJpZM4I1Vpw">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Zeiuh1spFGjVuTeMG-f5pUUUN82Pks5qLrnVgaJpZM4I1Vpw.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/670#issuecomment-225897805"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>