<p>This is a complete refactor of cdp log. In particular:</p>

<ul>
<li><p>It removes escape chars for colors in log: they are most of the times not interpreted so they are messing up the logs</p></li>
<li><p>It refactors some log level, moving to ERROR from WARN some errors during peer connections</p></li>
<li><p>In DEBUG level, cdp is too much verbose and also syslogs complains about rate-limiting. Instead of removing some logs (which is quite unfair), let's introduce a new modparam (debug_heavy) in order to activate some logs which gives some side informations about peers status. This modparam is not active by default but this can be enabled easily re-introducing previous debug logs</p></li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/692'>https://github.com/kamailio/kamailio/pull/692</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>cdp: Review log level on peer_connect() function</li>
  <li>cdp: Remove escape chars for colors in log</li>
  <li>cdp: Review of logging of cdp</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-0">modules/cdp/globals.h</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-1">modules/cdp/mod.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-2">modules/cdp/peermanager.c</a>
    (27)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-3">modules/cdp/peermanager.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-4">modules/cdp/peerstatemachine.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-5">modules/cdp/receiver.c</a>
    (34)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-6">modules/cdp/receiver.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-7">modules/cdp/session.c</a>
    (74)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-8">modules/cdp/session.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-9">modules/cdp/tcp_accept.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-10">modules/cdp/tcp_accept.h</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/692/files#diff-11">modules/cdp/transaction.c</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/692.patch'>https://github.com/kamailio/kamailio/pull/692.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/692.diff'>https://github.com/kamailio/kamailio/pull/692.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/692">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AF36ZYqQsYDZ6A2XrhKv4WpUySQqWqrGks5qRTeggaJpZM4JDRAk">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Zfc2dvqU7q3Aez3_8Xe5iicOZfJNks5qRTeggaJpZM4JDRAk.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/692"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>