<p>Hi Daniel,</p>

<p>I am using call load distribution algorithm calling <em>ds_select_dst</em> function with '10' as second argument, as described in <a href="http://kamailio.org/docs/modules/4.4.x/modules/dispatcher.html#dispatcher.f.ds_select_dst">dispatcher module doc files</a>.</p>

<p>The problem I notice is that <strong>all gateways without maxload attribute are discarded</strong>, even though the documentation says that if maxload is set to 0, no active call limit is used. The same thing happens if I set maxload to 0.</p>

<p>Reading the code I think the problem is in <a href="https://github.com/kamailio/kamailio/blob/4.4/modules/dispatcher/dispatch.c#L1452"><em>ds_get_leastloaded</em> function in dispatch.c file</a>.</p>

<p>This is the patch I have used:</p>

<pre><code>diff --git a/modules/dispatcher/dispatch.c b/modules/dispatcher/dispatch.c
index c1a831b..1e0064d 100644
--- a/modules/dispatcher/dispatch.c
+++ b/modules/dispatcher/dispatch.c
@@ -1449,7 +1449,8 @@ int ds_get_leastloaded(ds_set_t *dset)
    for(j=0; j<dset->nr; j++)
    {
        if(!ds_skip_dst(dset->dlist[j].flags)
-               && dset->dlist[j].dload<dset->dlist[j].attrs.maxload)
+               && (dset->dlist[j].attrs.maxload == 0
+                || dset->dlist[j].dload < dset->dlist[j].attrs.maxload))
        {
            if(dset->dlist[j].dload<t)
            {
</code></pre>

<p>I have done my tests with this version:</p>

<pre><code># kamailio -v
version: kamailio 4.4.3 (x86_64/linux) e43d82-dirty
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: e43d82 -dirty
compiled on 12:38:36 Sep 27 2016 with gcc 4.7.2
</code></pre>

<p>Thank you and regards,</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/800">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZQLWCJnvLMvCR-nHIY1xON6yykdMks5quSSLgaJpZM4KHt5u">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Zfs9iKtB6cyK-Kd8_AepGTEm-VoBks5quSSLgaJpZM4KHt5u.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/issues/800"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"dispatcher: Call load distribution forces maxload attribute (#800)"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/800"}}}</script>