<ul>
<li>In reviewing the code block that I removed it is actually duplicated
in the sca_create_cononical_aor_for_ua() function which is called from
sca_create_canonical_aor() which is called inside this 'if' block, so
why do it twice. The function sca_get_msg_contact_uri() is also called
in sca_create_cononical_aor_for_ua() but it does not set or pass a
'contact' parameter so we still need it in sca_call_info_update() just
don't need to check for errors because it will error out in
sca_create_cononical_aor_for_ua() and do the same thing.</li>
<li>Maybe in the long run for the 'contact_uri' parameter, create a second
function or add it as a setable paramter to the
sca_create_cononical_aor_for_ua().</li>
<li>Code change has been tested and running for about 2 months without
issues.</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/835'>https://github.com/kamailio/kamailio/pull/835</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>sca: sca_call_info.c: Remove redundant code</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/835/files#diff-0">modules/sca/sca_call_info.c</a>
    (32)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/835.patch'>https://github.com/kamailio/kamailio/pull/835.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/835.diff'>https://github.com/kamailio/kamailio/pull/835.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/835">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZVLPD30IjVMpMaSMZ6A1AHELWYxAks5q4eMQgaJpZM4KjXM9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Zd7zx_ndDV0ewPfJ8u3UvL-Yk9mfks5q4eMQgaJpZM4KjXM9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/835"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"sca: sca_call_info.c: Remove redundant code (#835)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/835"}}}</script>