<p>The way it works now, on a reply the SIP Status is inserted into the "method" field, this isn't very nice as, if you're working with the table, you'd need to actually look into the cseq and break it into Sequence and Method to be able to do anything useful. Then you'd need to check if the "method" field is an actual method or a status code. The patch makes it much more readable:</p>
<pre><code>+---------------------+------------------+--------+--------+-------------------------------+--------------------------------------+
| date | micro_ts | method | status | reply_reason | ruri |
+---------------------+------------------+--------+--------+-------------------------------+--------------------------------------+
| 2016-12-01 02:18:31 | 1480558711188146 | INVITE | | | sip:12345@1.2.3.4 |
| 2016-12-01 02:18:31 | 1480558711188584 | INVITE | 100 | Trying | |
| 2016-12-01 02:18:31 | 1480558711189884 | INVITE | 407 | Proxy Authentication Required | |
| 2016-12-01 02:18:31 | 1480558711391719 | ACK | | | sip:12345@1.2.3.4 |
| 2016-12-01 02:18:31 | 1480558711391871 | INVITE | | | sip:12345@1.2.3.4 |
| 2016-12-01 02:18:31 | 1480558711392194 | INVITE | 100 | Trying | |
| 2016-12-01 02:18:31 | 1480558711411499 | INVITE | 403 | Forbidden | |
| 2016-12-01 02:18:31 | 1480558711796623 | ACK | | | sip:12345@1.2.3.4 |
</code></pre>
<p>Which is easier to read than the current way:</p>
<pre><code>+---------------------+------------------+--------+-------------------------------+--------------------------------------+
| date | micro_ts | method | reply_reason | ruri |
+---------------------+------------------+--------+-------------------------------+--------------------------------------+
| 2016-12-01 02:18:31 | 1480558711188146 | INVITE | | sip:12345@1.2.3.4 |
| 2016-12-01 02:18:31 | 1480558711188584 | 100 | Trying | |
| 2016-12-01 02:18:31 | 1480558711189884 | 407 | Proxy Authentication Required | |
| 2016-12-01 02:18:31 | 1480558711391719 | ACK | | sip:12345@1.2.3.4 |
| 2016-12-01 02:18:31 | 1480558711391871 | INVITE | | sip:12345@1.2.3.4 |
| 2016-12-01 02:18:31 | 1480558711392194 | 100 | Trying | |
| 2016-12-01 02:18:31 | 1480558711411499 | 403 | Forbidden | |
| 2016-12-01 02:18:31 | 1480558711796623 | ACK | | sip:12345@1.2.3.4 |
</code></pre>
<p>Also, I'm doing a PR to homer as well to take into account this change, which will show in the "sip search" as a "Status" column.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/876#issuecomment-264192515">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZQGch1RRsurdJGor-N6dN7ORj9Omks5rDt77gaJpZM4LBcw8">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZUWZdKl5H2y8ohxIp5JpF2X9Wm6-ks5rDt77gaJpZM4LBcw8.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/876#issuecomment-264192515"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@davidcsi in #876: The way it works now, on a reply the SIP Status is inserted into the \"method\" field, this isn't very nice as, if you're working with the table, you'd need to actually look into the cseq and break it into Sequence and Method to be able to do anything useful. Then you'd need to check if the \"method\" field is an actual method or a status code. The patch makes it much more readable:\r\n\r\n```\r\n+---------------------+------------------+--------+--------+-------------------------------+--------------------------------------+\r\n| date | micro_ts | method | status | reply_reason | ruri |\r\n+---------------------+------------------+--------+--------+-------------------------------+--------------------------------------+\r\n| 2016-12-01 02:18:31 | 1480558711188146 | INVITE | | | sip:12345@1.2.3.4 |\r\n| 2016-12-01 02:18:31 | 1480558711188584 | INVITE | 100 | Trying | |\r\n| 2016-12-01 02:18:31 | 1480558711189884 | INVITE | 407 | Proxy Authentication Required | |\r\n| 2016-12-01 02:18:31 | 1480558711391719 | ACK | | | sip:12345@1.2.3.4 |\r\n| 2016-12-01 02:18:31 | 1480558711391871 | INVITE | | | sip:12345@1.2.3.4 |\r\n| 2016-12-01 02:18:31 | 1480558711392194 | INVITE | 100 | Trying | |\r\n| 2016-12-01 02:18:31 | 1480558711411499 | INVITE | 403 | Forbidden | |\r\n| 2016-12-01 02:18:31 | 1480558711796623 | ACK | | | sip:12345@1.2.3.4 |\r\n\r\n```\r\nWhich is easier to read than the current way:\r\n\r\n```\r\n+---------------------+------------------+--------+-------------------------------+--------------------------------------+\r\n| date | micro_ts | method | reply_reason | ruri |\r\n+---------------------+------------------+--------+-------------------------------+--------------------------------------+\r\n| 2016-12-01 02:18:31 | 1480558711188146 | INVITE | | sip:12345@1.2.3.4 |\r\n| 2016-12-01 02:18:31 | 1480558711188584 | 100 | Trying | |\r\n| 2016-12-01 02:18:31 | 1480558711189884 | 407 | Proxy Authentication Required | |\r\n| 2016-12-01 02:18:31 | 1480558711391719 | ACK | | sip:12345@1.2.3.4 |\r\n| 2016-12-01 02:18:31 | 1480558711391871 | INVITE | | sip:12345@1.2.3.4 |\r\n| 2016-12-01 02:18:31 | 1480558711392194 | 100 | Trying | |\r\n| 2016-12-01 02:18:31 | 1480558711411499 | 403 | Forbidden | |\r\n| 2016-12-01 02:18:31 | 1480558711796623 | ACK | | sip:12345@1.2.3.4 |\r\n\r\n```\r\n\r\nAlso, I'm doing a PR to homer as well to take into account this change, which will show in the \"sip search\" as a \"Status\" column.\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/876#issuecomment-264192515"}}}</script>