<p>We would like to know when the save("location") has generated a 503 message and as such we are thinking of modifying the save() function to return a code (like -2) for this error.</p>
<p>The default behaviour now seems to be that most errors in save() log a notice message, generate a reply via reg_send_reply() and then make sure that config doesn't go on with processing by returning 0. (tag "error:" in save() function definition)</p>
<p>Are you ok with such an intrusion in the code?</p>
<p>Thank you</p>
<p>Also, do you see an alternative to determining that this 503 message has been generated?</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/928'>https://github.com/kamailio/kamailio/pull/928</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>registrar: save() returns separate code on 503 generation</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/928/files#diff-0">src/modules/registrar/save.c</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/928.patch'>https://github.com/kamailio/kamailio/pull/928.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/928.diff'>https://github.com/kamailio/kamailio/pull/928.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/928">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZfSNpeV17xXFDvNiFFyzbwuqsqlOks5rR1NZgaJpZM4LivSB">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZcLj0TbMWrx_YPD4bd7rmsQHqz2Qks5rR1NZgaJpZM4LivSB.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/928"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"registrar: save() returns separate code on 503 generation (#928)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/928"}}}</script>