<div dir="ltr">Since it's safe to free(0) in general I do believe that proper fix would be to not warn in qm_free.</div><div class="gmail_extra"><br><div class="gmail_quote">2017-01-24 20:36 GMT+03:00 Ovidiu Sas <span dir="ltr"><<a href="mailto:osas@voipembedded.com" target="_blank">osas@voipembedded.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Module: kamailio<br>
Branch: master<br>
Commit: 7ae1384c7b944b4f6d49ad7deb5586<wbr>cc4e397882<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/7ae1384c7b944b4f6d49ad7deb5586cc4e397882" rel="noreferrer" target="_blank">https://github.com/kamailio/<wbr>kamailio/commit/<wbr>7ae1384c7b944b4f6d49ad7deb5586<wbr>cc4e397882</a><br>
<br>
Author: Ovidiu Sas <<a href="mailto:osas@voipembedded.com">osas@voipembedded.com</a>><br>
Committer: Ovidiu Sas <<a href="mailto:osas@voipembedded.com">osas@voipembedded.com</a>><br>
Date: 2017-01-24T12:33:54-05:00<br>
<br>
kazoo: avoid WARNING:qm_free: free(0) when kamailio shuts down on config parsing errors<br>
<br>
---<br>
<br>
Modified: src/modules/kazoo/kazoo.c<br>
Modified: src/modules/kazoo/kz_amqp.c<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/7ae1384c7b944b4f6d49ad7deb5586cc4e397882.diff" rel="noreferrer" target="_blank">https://github.com/kamailio/<wbr>kamailio/commit/<wbr>7ae1384c7b944b4f6d49ad7deb5586<wbr>cc4e397882.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/7ae1384c7b944b4f6d49ad7deb5586cc4e397882.patch" rel="noreferrer" target="_blank">https://github.com/kamailio/<wbr>kamailio/commit/<wbr>7ae1384c7b944b4f6d49ad7deb5586<wbr>cc4e397882.patch</a><br>
<br>
---<br>
<br>
diff --git a/src/modules/kazoo/kazoo.c b/src/modules/kazoo/kazoo.c<br>
index 7d4b03e..8c44391 100644<br>
--- a/src/modules/kazoo/kazoo.c<br>
+++ b/src/modules/kazoo/kazoo.c<br>
@@ -463,8 +463,8 @@ static int fire_init_event(int rank)<br>
<br>
static void mod_destroy(void) {<br>
kz_amqp_destroy();<br>
- shm_free(kz_worker_pipes_fds);<br>
- shm_free(kz_worker_pipes);<br>
+ if (kz_worker_pipes_fds) { shm_free(kz_worker_pipes_fds); }<br>
+ if (kz_worker_pipes) { shm_free(kz_worker_pipes); }<br>
}<br>
<br>
<br>
diff --git a/src/modules/kazoo/kz_amqp.c b/src/modules/kazoo/kz_amqp.c<br>
index 9c802aa..2111e89 100644<br>
--- a/src/modules/kazoo/kz_amqp.c<br>
+++ b/src/modules/kazoo/kz_amqp.c<br>
@@ -604,7 +604,7 @@ kz_amqp_server_ptr kz_amqp_destroy_server(kz_<wbr>amqp_server_ptr server_ptr)<br>
kz_amqp_server_ptr next = server_ptr->next;<br>
kz_amqp_destroy_connection(<wbr>server_ptr->connection);<br>
kz_amqp_destroy_channels(<wbr>server_ptr);<br>
- shm_free(server_ptr->producer)<wbr>;<br>
+ if (server_ptr->producer) { shm_free(server_ptr->producer)<wbr>; }<br>
shm_free(server_ptr);<br>
return next;<br>
}<br>
<br>
<br>
______________________________<wbr>_________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" rel="noreferrer" target="_blank">http://lists.sip-router.org/<wbr>cgi-bin/mailman/listinfo/sr-<wbr>dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Best regards,<br>Alekzander Spiridonov</div>
</div>