<p><b>@linuxmaniac</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/978#pullrequestreview-20569726">src/modules/pv/pv_core.c</a>:</p>
<pre style='color:#555'>> @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t *param, pv_value_t *res)
 
 int pv_parse_env_name(pv_spec_p sp, str *in)
 {
+       char *csname;
+
        if(in->s==NULL || in->len<=0)
</pre>
<p>I would do</p>
<pre><code>if(sp==NULL || in == NULL || in->len <=0)
</code></pre>
<p>as in the <a href="http://www.asipto.com/pub/kamailio-devel-guide/#c16_add_pv">kamailio-devel-guide</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/978#pullrequestreview-20569726">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZaOM67lWlxiBEZF4Of50a7JPMsB9ks5raKtlgaJpZM4L5xF0">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZUzyYgZqeOz9AtOmBkznm1KMkvE2ks5raKtlgaJpZM4L5xF0.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/978#pullrequestreview-20569726"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@linuxmaniac commented on #978"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/978#pullrequestreview-20569726"}}}</script>