<p>Backporting of new features in stable branches is not allowed, unless it is actually a fix or solving major security needs. Others can comment their opinion.</p>
<p>One more or less cosmetic opinion, I would make a class of variables, $ws(name), so if the future new fields can be added to it (like the implementation of $time(...) from pv modue). Also, for a short name of the attribute, maybe it can be used just 'orig_ip' instead of 'real_src_ip'.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1002#issuecomment-281032146">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZY4oQI6UVXpbG_lPWXhw-S3Felrtks5reWCXgaJpZM4MFqcu">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZUnWjEtm-j7TR0z9YVnDH8rIspMPks5reWCXgaJpZM4MFqcu.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1002#issuecomment-281032146"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1002: Backporting of new features in stable branches is not allowed, unless it is actually a fix or solving major security needs. Others can comment their opinion.\r\n\r\nOne more or less cosmetic opinion, I would make a class of variables, $ws(name), so if the future new fields can be added to it (like the implementation of $time(...) from pv modue). Also, for a short name of the attribute, maybe it can be used just 'orig_ip' instead of 'real_src_ip'."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1002#issuecomment-281032146"}}}</script>