<p><b>@tamiel</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1002#discussion_r102057762">src/modules/websocket/websocket.c</a>:</p>
<pre style='color:#555'>> +
+       if ((wsc = wsconn_get(msg->rcv.proto_reserved1)) == NULL) {
+               LM_ERR("$ws_real_src_ip cannot retrieve websocket connection\n");
+               return pv_get_null(msg, param, res);
+       }
+
+       wscid = wsc->id;
+
+       if (wsc->real_src_ip[0] == 0) {
+               wsconn_put(wsc);
+               LM_DBG("$ws_real_src_ip ws_conid %d real_src_ip is not set\n", wscid);
+               return pv_get_null(msg, param, res);
+       }
+
+       LM_DBG("$ws_real_src_ip ws_conid %d wsc->real_src_ip is %s (%d)\n", wscid, wsc->real_src_ip, (int)strlen(wsc->real_src_ip));
+       len = snprintf(buff, IP_ADDR_MAX_STR_SIZE, "%s", wsc->real_src_ip);
</pre>
<p>Right strncpy should do the job here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1002#discussion_r102057762">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZQaANLQGb8SkH4NN-wfQk2oxNogbks5recRKgaJpZM4MFqcu">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZSMxRIso99GCX3lq9zcspMb2oKJjks5recRKgaJpZM4MFqcu.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1002#discussion_r102057762"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tamiel commented on #1002"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1002#discussion_r102057762"}}}</script>