<p><b>@rfuchs</b> requested changes on this pull request.</p>

<p>There's a few mismatches between signed and unsigned left, but I think they can be resolved only up to a certain point, as Kamailio doesn't have support for unsigned types in certain areas</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/999#discussion_r102217100">src/modules/rtpengine/rtpengine.c</a>:</p>
<pre style='color:#555'>>                      pkg_free(*param);
-                       if((rtpp_list = select_rtpp_set(int_val)) ==0){
-                               LM_ERR("rtpp_proxy set %i not configured\n", int_val);
+                       if((rtpp_list = select_rtpp_set(set_id)) ==0){
+                               LM_ERR("rtpp_proxy set %i not configured\n", set_id);
</pre>
<p>format should be %u here</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/999#discussion_r102218163">src/modules/rtpengine/rtpengine.c</a>:</p>
<pre style='color:#555'>> @@ -1442,9 +1443,9 @@ mod_init(void)
        /* select the default set */
        default_rtpp_set = select_rtpp_set(setid_default);
        if (!default_rtpp_set) {
-               LM_NOTICE("Default rtpp set %d NOT found\n", setid_default);
+               LM_NOTICE("Default rtpp set %u NOT found\n", setid_default);
</pre>
<p>The type of <code>setid_default</code> itself also ought to be changed to unsigned accordingly</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/999#pullrequestreview-22966081">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZVsC8I9__4MeQpvY8mBnRPyrd4QVks5revUogaJpZM4MEJw0">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZZIUI1Vc9iVdWhHeNc1YwBN91f2Lks5revUogaJpZM4MEJw0.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/999#pullrequestreview-22966081"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rfuchs requested changes on #999"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/999#pullrequestreview-22966081"}}}</script>