<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1000#discussion_r102394137">src/modules/usrloc/ucontact.c</a>:</p>
<pre style='color:#555'>> @@ -1672,6 +1672,7 @@ static inline int update_contact_db(ucontact_t* _c)
  */
 int update_ucontact(struct urecord* _r, ucontact_t* _c, ucontact_info_t* _ci)
 {
+       static struct urecord _ur;
</pre>
<p>I don't see a reason to declare the variable _ur static here or in the other cases of the patch. It does not seem to be used outside of the function, so it can be declared locally (on the stack).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1000#pullrequestreview-23147003">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZVddqLIAy862oSC0u_0JmdAIV9cxks5re9sHgaJpZM4MEP5w">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZQhOe7VeZepHrva1QbCmgpLxY4Vuks5re9sHgaJpZM4MEP5w.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1000#pullrequestreview-23147003"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda commented on #1000"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1000#pullrequestreview-23147003"}}}</script>