<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1014#discussion_r104282624">src/modules/db_text/dbt_raw_query.c</a>:</p>
<pre style='color:#555'>> @@ -117,15 +117,22 @@ int dbt_raw_query_select(db1_con_t* _h, str* _s, db1_res_t** _r)
                result_cols = pkg_malloc(sizeof(db_key_t) * cols);
                memset(result_cols, 0, sizeof(db_key_t) * cols);
                for(n=0; n < cols; n++) {
-                       result_cols[n] = &_tbc->colv[n]->name;
+                       result_cols[n] = pkg_malloc(sizeof(str));
</pre>
<p>The result of mallocs are not checked if there is a valid pointer or NULL, which can happen on not enough memory available.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1014#pullrequestreview-25114726">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZbSrvfxzWuygsdRpXowYszUVGzyDks5riRicgaJpZM4MSij7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZQI0TXBJl3KkvZKUxYKvuDV8sFHMks5riRicgaJpZM4MSij7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1014#pullrequestreview-25114726"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda commented on #1014"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1014#pullrequestreview-25114726"}}}</script>