<p>Thanks for contributing!</p>
<p>Can you make a pull request only with the new module as a single commit? It will be easier to review and see if anything needs to be adjusted. Also, add xml docbook files with the documentation of the module, as the other modules have. We are not merging new modules without having the documentation written.</p>
<p>For drouting make another pull request because it may need dedicated review process to get the integration with keepalive.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1045#issuecomment-290095885">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZdgF5O1YzVifqUbrSb4A15ezep9mks5rqmGjgaJpZM4MqwO9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZQ8vs7WoQBQhwaZKnRXxS2ut6gDXks5rqmGjgaJpZM4MqwO9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1045#issuecomment-290095885"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1045: Thanks for contributing!\r\n\r\nCan you make a pull request only with the new module as a single commit? It will be easier to review and see if anything needs to be adjusted. Also, add xml docbook files with the documentation of the module, as the other modules have. We are not merging new modules without having the documentation written.\r\n\r\nFor drouting make another pull request because it may need dedicated review process to get the integration with keepalive."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1045#issuecomment-290095885"}}}</script>