[SR-Users] MSILO not checking Expires header if Allow: is absent and Contact: is present but without expires

[Daniel-Constantin Mierla]

Hello,

can you try the patch from next commit?

http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6559c4383858d472637807c6ec4dd1e0616507fa

If works ok, I will backport.

Cheers,
Daniel

On 18/07/14 21:04, Anthony Messina wrote:
> In setting up Kamailio with MSILO, I've noticed that some sip clients (I'm
> using CSipSimple), upon un-REGISTER-ing do not send an Allow header, but do
> send an "Expires: 0" header as well as a Contact header.
>
> However as the Contact header doesn't contain "expires=0", it appears as
> though the MSILO skips over checking the Expires header.
>
> As such, I've had to add the following workaround to my route[REGISTRAR] block
> or else these clients trigger the m_dump.
>
> # Ensure we aren't unregistering
> # Right now, CSipSimple doesn't send an Allow header with an un-REGISTER,
> # so Kamailio skips to checking the Contact header for expires, and appears
> # to ignore the fact that an Expires: 0 header is present.
> 	if($hdr(Expires) != 0)
> 		m_dump();
>
>
> Looking through the msilo  check_message_support function, it appears that it
> never checks for the Expires header if there is no Allow header and the
> Contact header does not specify an expire setting.
>
> I do believe that we're missing the check for the Expires header, regardless
> of whether or not there is an Allow header, or a Contact header with expires=0
> 	
>
> -A
>
>
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20140721/72ee7380/attachment.html>