[SR-Users] TOPOS (5.1.[23]) breaks PRACK

[George Diamantopoulos]

Hello all,

Thanks for the feedback, Henning. There seems to have already been a ticket
about this but it's closed now:
https://github.com/kamailio/kamailio/issues/2659

I'm a little confused here. It seems early-dialog UPDATE should be handled
similarly to PRACK, so I guess maybe a patch like
https://github.com/kamailio/kamailio/commit/37830f53b1f21fba5beef5d8e22913c431dcd708
would be needed.

However, Daniel has commented in this issue about the need to do
record_route() in config. To quote him: "The module requires record
routing, so if the UPDATE requires to re-enforce Record-Route, then you
have to do it. [...] I was aware that only NOTIFY requires to re-enforce
Record-Route, but can be also a matter of UA implementation to want it for
other requests."

However, RR reinforcement for NOTIFY only happens (in the kamailio sample
configuration file) in route[WITHINDLG] only if loose_route() check is
successful. In my case, UPDATEs fail this test, so control goes directly to
"sl_send_reply("404","Not here");", same as the author of the
aforementioned ticket. Unless Daniel meant one needs to reinforce RR for
PRACKs in order for subsequent UPDATEs to work?

Any thoughts?

BR,
George

On Wed, 6 Apr 2022 at 22:48, Henning Westerholt <hw at gilawa.com> wrote:

> Hello,
>
>
>
> Thanks for the update. Opening a github issue about it is probably a good
> idea.
>
>
>
> Cheers,
>
>
>
> Henning
>
>
>
> --
>
> Henning Westerholt – https://skalatan.de/blog/
>
> Kamailio services – https://gilawa.com
>
>
>
> *From:* sr-users <sr-users-bounces at lists.kamailio.org> *On Behalf Of *George
> Diamantopoulos
> *Sent:* Wednesday, April 6, 2022 7:29 PM
> *To:* Kamailio (SER) - Users Mailing List <sr-users at lists.kamailio.org>
> *Subject:* Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK
>
>
>
> This seems to be a topos issue regardless of backend, I tried with mariadb
> as storage and UPDATE routing fails in the same way as it does with redis.
> I'll probably open an issue on Github about this (early dialog UPDATE
> broken by topos). PRACK seems to work fine in my case. Direction of UPDATE
> vs PRACK however is different, not sure if that's important in any way.
>
>
>
> BR,
>
> George
>
>
>
> On Wed, 6 Apr 2022 at 06:31, George Diamantopoulos <georgediam at gmail.com>
> wrote:
>
> Hello again,
>
>
>
> I have confirmed the problem doesn't manifest without loading the topos
> module. I'll see if I can also try a different topos backend this week to
> confirm if this is a topos_redis issue or topos in general.
>
>
>
> BR,
>
> George
>
>
>
> On Tue, 22 Mar 2022 at 17:11, George Diamantopoulos <georgediam at gmail.com>
> wrote:
>
> Hello Henning,
>
>
>
> This is on kamailio 5.5.4.
>
>
>
> I'll try with a different backend and without topos and post the result
> here as soon as I find the time, just curious if anyone has stumbled on
> this with topos_redis before. Thanks!
>
>
>
> BR,
>
> George
>
>
>
> On Tue, 22 Mar 2022 at 15:51, Henning Westerholt <hw at gilawa.com> wrote:
>
> Hello,
>
>
>
> please give a recent 5.5.x Kamailio a try. There was a fix regarding
> early-dialog UPDATE handling in topos committed one year ago.
>
>
>
> Cheers,
>
>
>
> Henning
>
>
>
> --
>
> Henning Westerholt – https://skalatan.de/blog/
>
> Kamailio services – https://gilawa.com
>
>
>
> *From:* sr-users <sr-users-bounces at lists.kamailio.org> *On Behalf Of *George
> Diamantopoulos
> *Sent:* Monday, March 21, 2022 11:53 PM
> *To:* d.tryba at pocos.nl; Kamailio (SER) - Users Mailing List <
> sr-users at lists.kamailio.org>
> *Subject:* Re: [SR-Users] TOPOS (5.1.[23]) breaks PRACK
>
>
>
> Hello all,
>
>
>
> Any chance this could be affecting early-dialog UPDATE methods as well? I
> haven't tried with a different backend (mysql) yet, but loose_route returns
> false...
>
>
>
> BR,
>
> George
>
>
>
> On Fri, 25 May 2018 at 18:00, Daniel Tryba <d.tryba at pocos.nl> wrote:
>
> On Wed, May 23, 2018 at 10:51:37PM +0200, Daniel-Constantin Mierla wrote:
> > I got a bit of time to look at this issue, can you try with the patch
> > from the next commit?
> >
> > ?? -
> >
> https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129
> >
>
> This off by 1 fix solved the PRACK issue with redis backend.
>
>
> _______________________________________________
> Kamailio (SER) - Users Mailing List
> sr-users at lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-users/attachments/20220407/f7fe4ce1/attachment.htm>