Thanks for the feedback all. <br>
<br>
I've been considering what to do with this issue, and I decided that it
is better to (but more painful) to have the vendor fix their firmware
than it is for me to alter SER's functionality in a way as to move it
away from RFC compliance.<br>
<br>
The save_extended_expires suggestion would be an easy fix, but the right thing to do is fix the problem rather than the symptom.<br>
<br>
Regards,<br>
Paul<br><br><div><span class="gmail_quote">On 6/21/05, <b class="gmail_sendername">Samuel Osorio Calvo</b> <<a href="mailto:samuel.osorio@nl.thalesgroup.com">samuel.osorio@nl.thalesgroup.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I
was taking a more detailled look at the code and it seems that the
Contact header will not be added into the reply if you use
save_noreply+sl_send_reply because the Contact buffer is added inside
the registrar module....but I recall that it worked. I suggest you to
give it a try and see the answer with ethereal|ngrep|* maybe it is
taken after when constructing the answer from the sipmsg.<br>Anyhow it
would be easy to add a save_extended_expires command that makes what
you need but, as I said, people can start using these SIP patches to
build even more non-compliant proxies with SER....<br><br>Samuel.<br><br><br>Unclassified.<br>>>> "Greger V. Teigre" <<a href="mailto:greger@teigre.com">greger@teigre.com</a>> 06/21/05 07:19AM >>>
<br>You're right of course :-)<br>Samuel's
approach is more correct, but I'm not sure you will be able to generate
the correct reply using save_noreply and sl_reply (with Contact)
?! Does save_noreply generate the reply?<br>g-)<br><br>---- Original Message ----<br>From: Java Rockx<br>To: Greger V. Teigre<br>Cc: serusers<br>Sent: Monday, June 20, 2005 02:21 PM<br>Subject: Re: [Serusers] Is there an AVP to alter "expires=" in
<br>REGISTERmessages?<br><br>> Greger,<br>><br>> That would be possible, but the way SER generates the 200OK reply, it<br>> would contain the altered "expires=" value. By doing so, the ATA<br>> would take that new value and use it, so if the ATA sent the REGISTER
<br>> with an expires=300 and SER replied with a 200OK and a contact header<br>> containing expires=360, the ATA would not send another REGISTER for<br>> 360 seconds.<br>><br>> I was fooling around with sip_msg.c and
reply.c were I padded the<br>> expires with 60 seconds before saving to usrloc and then removing the<br>> pad before sending the reply and it works, but I would just feel<br>> better by not altering the source code.
<br>><br>> I guess I'd just feel more comfortable if SER had some sort of AVP or<br>> modparam for the registrar module that did this automagically.<br>><br>> Regards,<br>> Paul<br>><br>><br>> On 6/20/05, Greger V. Teigre <
<a href="mailto:greger@teigre.com">greger@teigre.com</a>> wrote:<br>> It was supposed to be short, but maybe too short. I meant doing the<br>> subst on the REGISTER message before save.<br>> g-)<br>> ---- Original Message ----
<br>> From: Greger V. Teigre<br>> To: Java Rockx ; serusers<br>> Sent: Monday, June 20, 2005 09:01 AM<br>> Subject: Re: [Serusers] Is there an AVP to alter "expires=" in<br>> REGISTERmessages?<br>
><br>>> Hi Paul,<br>>> Would it be possible to "do it upside down" ? ;-) I.e. do a<br>>> subst("/^Expires:(.*)[0-9]$/ Expires: yourvalue+60/gi");<br>>> g-)<br>>><br>>> ---- Original Message ----
<br>>> From: Java Rockx<br>>> To: serusers<br>>> Sent: Sunday, June 19, 2005 04:28 PM<br>>> Subject: [Serusers] Is there an AVP to alter "expires=" in REGISTER<br>>> messages?<br>>>
<br>>>> Hi All.<br>>>><br>>>> We've got some ATAs that don't quite re-REGISTER in a timely fashion<br>>>> and therefore SER expires the usrloc record a few seconds before the<br>>>> ATA sends another REGISTER message.
<br>>>><br>>>> Is there an AVP or something to add, for example, 60 seconds to the<br>>>> "expires=" value in the REGISTER message prior to calling save()? By<br>>>> doing so, these "broken" ATAs would re-REGISTER before SER removes
<br>>>> the usrloc record from cache.<br>>>><br>>>> Regards,<br>>>> Paul<br>>>><br>>>><br>>>><br>>>><br>>>> _______________________________________________
<br>>>> Serusers mailing list<br>>>> <a href="mailto:Serusers@iptel.org">serusers@lists.iptel.org</a><br>>>> <a href="http://mail.iptel.org/mailman/listinfo/serusers">http://lists.iptel.org/mailman/listinfo/serusers
</a><br>>><br>>><br>>><br>>> _______________________________________________<br>>> Serusers mailing list<br>>> <a href="mailto:serusers@lists.iptel.org">serusers@lists.iptel.org</a><br>>> <a href="http://lists.iptel.org/mailman/listinfo/serusers">
http://lists.iptel.org/mailman/listinfo/serusers</a><br><br></blockquote></div><br>