Daniel<br><br>Are you sure that this source fragment (in nhelpr_funcs.c):<br><br> /* no need for parse_headers(msg, EOH), get_body will<br> * parse everything */<br> /*is the content type correct?*/<br>
if((ret = check_content_type(msg))==1)<br> {<br> LM_ERR("content type mismatching\n");<br> goto error;<br> }<br><br>shouldn't be <br><br> /* no need for parse_headers(msg, EOH), get_body will<br>
* parse everything */<br>
/*is the content type correct?*/<br>
if((ret = check_content_type(msg))== -1)<br>
{<br>
LM_ERR("content type mismatching\n");<br>
goto error;<br>
}<br>
<br>? ( "==1" --> "==-1")<br><br>Because now it gives me errors when processing INVITE with application/sdp payload.<br><br>-pascal<br><br><br><div class="gmail_quote">On Tue, Jun 23, 2009 at 10:59 AM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
<br>
On 06/23/2009 10:16 AM, Pascal Maugeri wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
This bug is fixed now with your patch Daniel!<br>
Thank you, I go ahead with my testing<br>
</blockquote></div>
ok, I will backport to kamailio 1.5 in few days if there is no related bug reported meanwhile.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Cheers,<br>
Pascal<div><div></div><div class="h5"><br>
<br>
<br>
On Mon, Jun 22, 2009 at 5:34 PM, Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a> <mailto:<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>> wrote:<br>
<br>
Can you check this patch I just committed?<br>
<br>
<a href="http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=caef5ace2026fcb2a9dffb471e2cec6d843082f8" target="_blank">http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=caef5ace2026fcb2a9dffb471e2cec6d843082f8</a><br>
<br>
Basically, you simply can get the extract_body() function from<br>
nathelper/nhelpr_funcs.c and replace it in kamailio.<br>
<br>
Let me know if works ok now.<br>
<br>
Thanks,<br>
Daniel<br>
<br>
<br>
On 06/22/2009 04:22 PM, Daniel-Constantin Mierla wrote:<br>
<br>
please send me the original and the new invite so I can see<br>
how the body is changed afterwards.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
On 06/22/2009 03:23 PM, Pascal Maugeri wrote:<br>
<br>
With your patch there is a small bug when re-constructing<br>
the multipart payload:<br>
<br>
[...]<br>
--Genaker-boundary<br>
Content-Type: application/sdp<br>
<br>
v=0<br>
[...]<br>
a=fmtp:TBCP queuing=0; tb_priority=1; timestamp=0;<br>
tb_granted=0; poc_sess_priority=1; poc_lock=0<br>
<br>
<br>
*a=nortpproxy:yes--Genaker-boundary*<br>
Content-Type: application/resource-lists+xml<br>
<br>
<?xml version="1.0" encoding="UTF-8"?><br>
<resource-lists<br>
xmlns="urn:ietf:params:xml:ns:resource-lists"<br>
xmlns:xsi="<a href="http://www.w3.org/2001/XMLSchema-instance" target="_blank">http://www.w3.org/2001/XMLSchema-instance</a>"><br>
[...]<br>
<br>
--Genaker-boundary--<br>
<br>
<br>
Observe the line "a=nortpproxy:yes--Genaker-boundary" :<br>
there are CRLFs missing. And there two CRLF before<br>
"a=nortpproxy:yes". I guess you're adding the CRLF in the<br>
incorrect order.<br>
<br>
We're progressing ;-)<br>
<br>
-pascal<br>
<br>
On Mon, Jun 22, 2009 at 11:36 AM, Daniel-Constantin Mierla<br>
<<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a> <mailto:<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>><br></div></div><div><div></div><div class="h5">
<mailto:<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a> <mailto:<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>>> wrote:<br>
<br>
Hello Pascal,<br>
<br>
I have just committed support for multipart bodies in<br>
sip router,<br>
if works then I will backport to 1.5.<br>
<br>
<a href="http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1f41271e1c1b879217835b8b3fdbdc2680138f25" target="_blank">http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1f41271e1c1b879217835b8b3fdbdc2680138f25</a><br>
<br>
<br>
<br>
Can you test it? Unfortunately I cannot do it these<br>
days properly<br>
due to traveling. Patch should work pretty<br>
straightforward with<br>
1.5 though, if you want to test it directly there.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
On 06/22/2009 11:30 AM, Pascal Maugeri wrote:<br>
<br>
I tried to install mediaproxy but it looks tricky<br>
to install<br>
(many dependencies, including kernel specific<br>
configurations) :-(<br>
and I would like to stick to rtpproxy for<br>
performance reason.<br>
<br>
Do you believe the same workaround using<br>
textops/filter_body<br>
can be used using rtpproxy ? I think yes as these<br>
are two<br>
different things as said Juha.<br>
<br>
Regards,<br>
Pascal<br>
<br>
<br>
On Fri, Jun 19, 2009 at 9:26 PM, Pascal Maugeri<br>
<<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a>><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a>>><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a>><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a><br>
<mailto:<a href="mailto:pascal.maugeri@gmail.com" target="_blank">pascal.maugeri@gmail.com</a>>>>> wrote:<br>
<br>
<br>
<br>
On Fri, Jun 19, 2009 at 9:13 PM, Juha Heinanen<br>
<<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a> <mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a>><br>
<mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a> <mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a>>><br>
<mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a> <mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a>><br>
<mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a> <mailto:<a href="mailto:jh@tutpro.com" target="_blank">jh@tutpro.com</a>>>>> wrote:<br>
<br>
Pascal Maugeri writes:<br>
<br>
> So if I understand well (please correct<br>
me if I'm wrong)<br>
the "plan" is:<br>
><br>
> 1º) I install MediaProxy and use Kamailio<br>
MEDIAPROXY<br>
module<br>
instead of<br>
> rtpproxy/NATHelper<br>
><br>
> 2º) filter the app/sdp part with<br>
><br>
> if (has_body("multipart/mixed")) {<br>
> if (filter_body("application/sdp") {<br>
> remove_hf("Content-Type");<br>
><br>
> append_hf("Content-Type:<br>
application/sdp\r\n");<br>
> } else {<br>
><br>
> xlog("Body part application/sdp<br>
not found\n");<br>
> }<br>
> }<br>
<br>
you don't need to call filter_body if you<br>
use mediaproxy.<br>
<br>
> 3º) then engage the media proxy with<br>
><br>
> if (method==INVITE && !has_totag()) {<br>
><br>
> # We can also use a specific media<br>
relay if we<br>
need to<br>
> #$avp(s:media_relay) = "1.2.3.4";<br>
> engage_media_proxy();<br>
> }<br>
<br>
i have never used engage_media_proxy()<br>
functions,<br>
because it<br>
makes some<br>
assumptions that are not generally true. i use<br>
use_media_proxy() instead.<br>
<br>
> 4º) finally put the body part(s) that<br>
have been<br>
removed in<br>
1º) and relay the<br>
> INVITE to my next hop.<br>
> I believe I can save the body<br>
part(s) in 1º)<br>
and put<br>
them back using<br>
> set_body(txt, content_type).<br>
<br>
you don't need to do anything like that if<br>
you use<br>
use_media_proxy()<br>
function, because it does not remove anything.<br>
<br>
<br>
Thanks Juha ! I can't wait for monday to test it :-)<br>
<br>
Have a nice week-end<br>
Pascal<br>
<br>
-- juha<br>
<br>
<br>
<br>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a><br>
<mailto:<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a>><br>
<mailto:<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a><br>
<mailto:<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a>>><br>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
-- Daniel-Constantin Mierla<br>
<a href="http://www.asipto.com/" target="_blank">http://www.asipto.com/</a><br>
<br>
<br>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a> <mailto:<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a>><br>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
<br>
-- Daniel-Constantin Mierla<br>
<a href="http://www.asipto.com/" target="_blank">http://www.asipto.com/</a><br>
<br>
<br>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
Kamailio (OpenSER) - Users mailing list<br>
<a href="mailto:Users@lists.kamailio.org" target="_blank">Users@lists.kamailio.org</a><br>
<a href="http://lists.kamailio.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.kamailio.org/cgi-bin/mailman/listinfo/users</a><br>
<a href="http://lists.openser-project.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.openser-project.org/cgi-bin/mailman/listinfo/users</a><br>
</div></div></blockquote><div><div></div><div class="h5">
<br>
-- <br>
Daniel-Constantin Mierla<br>
<a href="http://www.asipto.com/" target="_blank">http://www.asipto.com/</a><br>
<br>
</div></div></blockquote></div><br>