Hi,<br><br>now I'm using t_flush_flags() after setting the
accounting flag in falure_route and latest
updates (I have a new 3.1 clone without depth parameter and I've made
sure your changes are in sources), but it doesn't solve the case,
accounting behavior is still exactly the same as described in the first
mail. <br>
<br>If it is of any help, previously I've tested the same scenario where
I was setting the accounting flag in RELAY and LOCATION routes which
were called from failure route. <br><br>Cheers<br><font color="#888888">Ozren</font><br><br><div class="gmail_quote">On Mon, Sep 12, 2011 at 9:19 AM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
over the weekend I backported the implementation of t_flush_flags()
as well as auto-update of transaction flags after branch/failure
route. Just pull the latest branch 3.1 and you are ready to
compile/install.<br>
<br>
Let us know if it solves the case.<br>
<br>
Cheers,<br><font color="#888888">
Daniel</font><div><div></div><div class="h5"><br>
<br>
On 9/9/11 2:40 PM, Daniel-Constantin Mierla wrote:
<blockquote type="cite">
Hello,<br>
<br>
when you pulled the GIT branch 3.1, did you use --depth 1, like
next?<br>
<br>
git clone --depth 1 git://<a href="http://git.sip-router.org/sip-router" target="_blank">git.sip-router.org/sip-router</a> kamailio<br>
<br>
The you just got the snapshot at that time without the history of
the commit and probably you did the git clone after I did the
commit, a new git pull taking newer commit. So try cloning again
the latest branch 3.1, without --depth 1 parameter.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
On 9/7/11 2:20 PM, Ozren Lapcevic wrote:
<blockquote type="cite">Hi,<br>
<br>
I've previously installed kamailio from git branch 3.1. Now,
I've manged to git cherry-pick your patch, but got "fatal: Could
not find 83620cb7cd14ee3b509eef72d99337567f53967f" when tried to
get t_flush_flags(). I've double-checked commit and found it
here: <a href="http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commit;h=83620cb7cd14ee3b509eef72d99337567f53967f" target="_blank">http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commit;h=83620cb7cd14ee3b509eef72d99337567f53967f</a>.
I don't know why I can't cherry-pick it.<br>
<br>
Your patch alone, without t_flush_flags(), doesn't change
anything in my scenario, there is still no logging of 2nd
branch. <br>
<br>
Cheers<br>
Ozren<br>
<br>
<br>
<div class="gmail_quote">On Wed, Sep 7, 2011 at 1:05 PM,
Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,
<div><br>
<br>
On 9/7/11 11:25 AM, Ozren Lapcevic wrote:
<blockquote type="cite">Hi Daniel, <br>
<br>
thanks for the quick fix and reply.<br>
<br>
What is the easiest way to try this new patch? I'm
running kamailio 3.1.4 and there is no t_flush_flags()
in tmx module in that version. I suppose I need to
install Kamailio Devel from git (<a href="http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-devel-from-git" target="_blank">http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-devel-from-git</a>)
to get t_flush flags() and your patch or is there a
workaround to apply them to my 3.1.4 branch?<br>
</blockquote>
<br>
</div>
did you install 3.1.4 from tarball/packages or is it from
git branch 3.1? If later, then you can do:<br>
<br>
git pull origin<br>
git cherry-pick -x
83620cb7cd14ee3b509eef72d99337567f53967f<br>
git cherry-pick -x
c589ca35b2aa3097a3c9e2a5a050514337300c05<br>
<br>
then recompile/install. First cherry-pick brings the
t_flush_flags, the second auto-update of the flags after
branch/failure route.<br>
<br>
If you installed from packages, then you would need to
repackage yourself after patching. The patches are
available at commit url, for example:
<div><br>
<br>
<a href="http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c589ca35b2aa3097a3c9e2a5a050514337300c05" target="_blank">http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c589ca35b2aa3097a3c9e2a5a050514337300c05</a><br>
<br>
</div>
There you find at top of the page a link named 'patch'
that you can use with git tools to apply or extract the
diff-patch part and apply with patch.<br>
<br>
Cheers,<br>
<font color="#888888"> Daniel</font>
<div>
<div><br>
<blockquote type="cite"> <br>
Cheers<br>
Ozren<br>
<br>
<br>
<div class="gmail_quote">On Tue, Sep 6, 2011 at 2:18
PM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,<br>
<br>
can you use t_flush_flags() after setting the
accounting flag in falure_route? Automatic
update was missing so far, reported by Alex
Hermann as well. I just did a patch, so if you
want to try it, see the commit:<br>
<br>
<a href="http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c589ca35b2aa3097a3c9e2a5a050514337300c05" target="_blank">http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c589ca35b2aa3097a3c9e2a5a050514337300c05</a><br>
<br>
Actually, reporting if all goes fine with this
patch, will help in backporting it to 3.1
branch.<br>
<br>
Thanks,<br>
Daniel<br></div></blockquote></div></blockquote></div></div></div></blockquote></div></blockquote></blockquote></div></div></div></blockquote></div><br>