<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
<div class="moz-cite-prefix">On 7/6/12 1:36 AM, Andreas Granig
wrote:<br>
</div>
<blockquote cite="mid:4FF624E5.8050404@sipwise.com" type="cite">
<pre wrap="">Hi,
The attached patch does the trick for me, but I'd rather like to have a
second opinion on it for any potential side effects before pushing it.</pre>
</blockquote>
<br>
looks ok, go ahead and push it in master and then backport it.<br>
<br>
<blockquote cite="mid:4FF624E5.8050404@sipwise.com" type="cite">
<pre wrap="">
The point here is that the fixup function didn't change (beside the
name) between 3.1 and 3.3, however 3.1 used dedicated w_replace_from1()
and w_replace_from2(), whereas 3.3 uses one unified w_replace_from(),
which breaks the behavior the fixup function is providing.</pre>
</blockquote>
<br>
I see, thanks for clarifications.<br>
<br>
Cheers,<br>
Daniel<br>
<blockquote cite="mid:4FF624E5.8050404@sipwise.com" type="cite">
<pre wrap="">
Thanks,
Andreas
On 07/05/2012 12:32 AM, Andreas Granig wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
On 07/04/2012 09:42 PM, Daniel-Constantin Mierla wrote:
</pre>
<blockquote type="cite">
<pre wrap="">quick look into the sources shows that fixup makes the display parameter
null if its length is 0 -- perhaps introduced in the patch that unified
the fixup to work also for replacing the To header display. If you have
time and urgent need, you can push a fix for it asap, otherwise I will
look at it once getting some spare time out of traveling.
</pre>
</blockquote>
<pre wrap="">
Ok, I'll have a look at it tomorrow and push a fix.
Andreas
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Training, Seattle, USA, Sep 23-26, 2012 - <a class="moz-txt-link-freetext" href="http://asipto.com/u/katu">http://asipto.com/u/katu</a>
Kamailio Practical Workshop, Netherlands, Sep 10-12, 2012 - <a class="moz-txt-link-freetext" href="http://asipto.com/u/kpw">http://asipto.com/u/kpw</a></pre>
</body>
</html>