<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Make the patch for master branch, 4.0 doesn't take any new feature
and I applied the patches to master branch anyhow.<br>
<br>
Also, do not forget the patch for xml documentation.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 9/5/13 9:27 AM, Vitaliy Aleksandrov
wrote:<br>
</div>
<blockquote cite="mid:52283269.6050200@gmail.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">This patch has a bug which leads to
false contact removal.<br>
<br>
This happens when UA reconnects to a proxy from the same src
port and sends new REGISTER with the same Contact. In that case
kamailio updates an existing contact and I forgot to update tcp
connection id in the ucontact_t object.<br>
<br>
I've fixed this bug in my production system (kamailio-3.2) and
it works well.<br>
The patch for 4.0.3 will be ready tonight.<br>
</div>
<blockquote cite="mid:5226FD79.3050709@gmail.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hello,<br>
<br>
I applied your patches with some changes. There is no need to
store tcp connection id in other structure in the core, it is
stored in msg->rcv.proto_reserved1.<br>
<br>
You have to add the documentation for the new usrloc parameter,
in xml files from modules/usrloc/doc/ - send over the patch and
I will commit it as well.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 8/29/13 12:47 PM, Vitaliy
Aleksandrov wrote:<br>
</div>
<blockquote cite="mid:521F26D7.4060701@gmail.com" type="cite">Thanks
community for all replies. <br>
<br>
I did the second try. Result is in the attachment. <br>
<br>
This time a did it in the way proposed by Daniel-Constantin
Mierla. <br>
All job is done in timer process when it iterates through all
registrations looking for expired ones. <br>
<br>
It works for all database modes except DB_ONLY. <br>
<br>
I'm not sure about tcpconn_get() / tcpconn_put() functions.
tcpconn_get() increments ref counter, but there are several
function to decrement it: tcpconn_put(), tcpconn_chld_put()
and atomic_dec_and_test(). When I was looking for examples in
other modules I saw that tcp_read.c uses tcpconn_chld_put(),
but forward.h and msg_translator.c uses only tcpconn_get()
without decrementing ref counter at all. <br>
<br>
It would be great if somebody more experienced shed some light
on this. <br>
<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Oct 21-24; Miami, Nov 11-13, 2013
- more details about Kamailio trainings at <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a> -
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Oct 21-24; Miami, Nov 11-13, 2013
- more details about Kamailio trainings at <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a> -
</pre>
</body>
</html>