<div dir="ltr"><div>Thanks for the feedback -- Here is my updated version.</div><div><div><br></div><div><br></div><div><br></div><div>modparam("htable", "htable", "htable_source_group_rates_sec=>size=8;dbtable=htable_source_group_rates_sec;initval=0;autoexpire=300;")</div>
<div>modparam("htable", "htable", "htable_source_group_rates_min=>size=8;dbtable=htable_source_group_rates_min;initval=0;autoexpire=1800;")</div><div>modparam("htable", "htable", "htable_source_group_limits=>size=8;dbtable=htable_source_group_limits;initval=500;")</div>
</div><div><br></div><div><br></div><div><br></div><div>route[SOURCE_GROUP_LIMIT] {</div><div><br></div><div><span class="" style="white-space:pre"> </span>if (is_method("INVITE")){</div><div><span class="" style="white-space:pre"> </span>$var(rateHashSec) = (str)$var(srcgroup)+":sec:"+$timef(%Y/%m/%d_%H_%M_%S);</div>
<div><span class="" style="white-space:pre"> </span>$var(rateHashMin) = (str)$var(srcgroup)+":min:"+$timef(%Y/%m/%d_%H_%M_00);</div><div><span class="" style="white-space:pre"> </span></div><div><span class="" style="white-space:pre"> </span>$var(ratePerSec) = $shtinc(htable_source_group_rates_sec=>$var(rateHashSec));</div>
<div><span class="" style="white-space:pre"> </span>$var(ratePerMin) = $shtinc(htable_source_group_rates_min=>$var(rateHashMin));</div><div><span class="" style="white-space:pre"> </span>$var(limitPerSec) = $sht(htable_source_group_limits=>$var(srcgroup));</div>
<div><span class="" style="white-space:pre"> </span></div><div><span class="" style="white-space:pre"> </span>if($var(ratePerSec) > $var(limitPerSec))</div><div><span class="" style="white-space:pre"> </span>{</div>
<div><span class="" style="white-space:pre"> </span>sl_send_reply("503", "$si over source Limit of $var(ratePerSec)) / $var(limitPerSec)");</div><div><span class="" style="white-space:pre"> </span>exit;</div>
<div><span class="" style="white-space:pre"> </span>}</div><div><span class="" style="white-space:pre"> </span>}</div><div>}</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 12 September 2013 21:31, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
nice approach and glad to see I could throw some seeds for new ideas
out there!<br>
<br>
You should use $shtinc(...), like:<br>
<br>
$var(rps) =
$shtinc(htable_source_group_rates=>$var(rateHashSec));<br>
$var(rpm) =
$shtinc(htable_source_group_rates=>$var(rateHashMin));<br>
<br>
In this way you avoid races on increment operation done with '+'.
Alternatives would be to use locks via cfgutils module.<br>
<br>
Then you can use $var(...) for test if you want to allow the
requests that came below the limit, or the current value with
$sht(...) to block if there were other requests coming meanwhile
(after the increment).<br>
<br>
Cheers,<br>
Daniel<div><div class="h5"><br>
<br>
<div>On 9/12/13 9:21 PM, Gareth Rylance
wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">
<div><br>
</div>
<div><br>
</div>
<div>I was inspired by Daniels ClueCon 2013 talk and have decide
to try to add simple rate limiting using a HTable.</div>
<div>$var(srcgroup) is an id that identifies the invites source/
I wish to limit invites from a given source.<br>
</div>
<div><br>
</div>
<div>$var(rateHashMin) was added just to allow simple
monitoring.</div>
<div>I query the table via XML-RPC to get an idea of current
load. </div>
<div>I think it would be better to add it to a seperate table
and then I could increase the exprires time to capture more of
the course grain points.</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>I am interested in any comments.<br>
</div>
<div><br>
</div>
<div> <br>
</div>
<div>----------------------</div>
<div>
<div>modparam("htable", "htable",
"htable_source_group_rates=>size=8;dbtable=htable_source_group_rates;initval=0;autoexpire=300;")</div>
<div>modparam("htable", "htable",
"htable_source_group_limits=>size=8;dbtable=htable_source_group_limits;initval=500;")</div>
</div>
<div>----------------------<br>
</div>
<div>----------------------<br>
</div>
<div>route[SOURCE_GROUP_LIMIT] {</div>
<div><br>
</div>
<div><span style="white-space:pre-wrap"> </span>if
(is_method("INVITE")){</div>
<div><span style="white-space:pre-wrap"> </span>$var(rateHashSec)
= (str)$var(srcgroup)+":sec:"+$timef(%Y/%m/%d_%H_%M_%S);</div>
<div><span style="white-space:pre-wrap"> </span>$var(rateHashMin)
= (str)$var(srcgroup)+":min:"+$timef(%Y/%m/%d_%H_%M_00);</div>
<div><span style="white-space:pre-wrap"> </span></div>
<div><span style="white-space:pre-wrap"> </span></div>
<div><span style="white-space:pre-wrap"> </span>$sht(htable_source_group_rates=>$var(rateHashSec))
= $sht(htable_source_group_rates=>$var(rateHashSec)) + 1;</div>
<div><span style="white-space:pre-wrap"> </span>$sht(htable_source_group_rates=>$var(rateHashMin))
= $sht(htable_source_group_rates=>$var(rateHashMin)) + 1;<span style="white-space:pre-wrap"> </span></div>
<div><span style="white-space:pre-wrap"> </span></div>
<div><span style="white-space:pre-wrap"> </span>if($sht(htable_source_group_rates=>$var(rateHashSec))
> $sht(htable_source_group_limits=>$var(srcgroup)))</div>
<div><span style="white-space:pre-wrap"> </span>{</div>
<div><span style="white-space:pre-wrap"> </span>sl_send_reply("503",
"$si over source Limit of
$sht(htable_source_group_rates=>$var(rateHashSec)) /
$sht(htable_source_group_limits=>$var(srcgroup)");</div>
<div><span style="white-space:pre-wrap"> </span>exit;</div>
<div><span style="white-space:pre-wrap"> </span>}</div>
<div><span style="white-space:pre-wrap"> </span>}</div>
<div>}</div>
<div>----------------------<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Thanks Gareth</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a href="mailto:sr-users@lists.sip-router.org" target="_blank">sr-users@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><span class="HOEnZb"><font color="#888888">
</font></span></pre><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<pre cols="72">--
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Oct 21-24; Miami, Nov 11-13, 2013
- more details about Kamailio trainings at <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a> -
</pre>
</font></span></div>
<br>_______________________________________________<br>
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list<br>
<a href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><br>
<br></blockquote></div><br></div>