<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
thanks for digging further, I will check it and commit if all looks
good.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 9/29/13 5:55 PM, Øyvind Kolbu wrote:<br>
</div>
<blockquote cite="mid:20130929155530.GA12504@putsch.kolbu.ws"
type="cite">
<pre wrap="">On 2013-09-27 at 13:42, Øyvind Kolbu wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 2013-09-27 at 11:49, Daniel-Constantin Mierla wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Haven't got time to get back to it -- hope to happen soon.
</pre>
</blockquote>
<pre wrap="">
I've taken a small peak and think I at least found some of the problem, but
also got quite confused.
What is the relationship between
dns_cache.c:dns_srv_sip_resolvehost() and
dns_cache.c:dns_srv_sip_resolve()? They look very much copy and paste, with
the same error in them. Both will only search for UDP records if *proto is
not set. They also mangle the *proto value as they both set it to
PROTO_UDP if it is unset, and the leaves it that way instead of resetting
it to 0.
In resolve.c:no_naptr_srv_sip_resolvehost() a proper SRV lookup function is
defined, but not used at least for the t_relay() case. Perhaps change both
functions in dns_cache.c to use no_naptr_srv_sip_resolvehost?
</pre>
</blockquote>
<pre wrap="">
The patch attached fixes the no NAPTR and no UDP case, but only when
use_dns_failover is set to off. We usually have it on, but I can't recall
why..
Anyhow the patch is rather trivial, just store *proto before overwriting it
and restore it before calling no_naptr_srv_sip_resolvehost.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013
- more details about Kamailio trainings at <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a> -
</pre>
</body>
</html>