<div dir="ltr">Hi Daniel,<div><br></div><div>The patch has tested OK so far.</div><div><br></div><div>Regards,</div><div><br></div><div>Charles</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On 22 August 2014 12:37, Charles Chance <span dir="ltr"><<a href="mailto:charles.chance@sipcentric.com" target="_blank">charles.chance@sipcentric.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<p dir="ltr">Thanks, Daniel.</p>
<p dir="ltr">It can be hours, days or weeks between occurrences, but I will report back after a day or two initially then continue to monitor.</p>
<p dir="ltr">Cheers,</p>
<p dir="ltr">Charles<br>
</p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On 22 Aug 2014 12:18, "Daniel-Constantin Mierla" <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
can you try this small patch?<br>
<br>
diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c
b/modules/pua_dialoginfo/pua_dialoginfo.c<br>
index 1e88a04..0f02b2b 100644<br>
--- a/modules/pua_dialoginfo/pua_dialoginfo.c<br>
+++ b/modules/pua_dialoginfo/pua_dialoginfo.c<br>
@@ -347,7 +347,7 @@ struct str_list* get_str_list(unsigned short
avp_flags, int_str avp_name) {<br>
<br>
memset( list_current, 0, len);<br>
<br>
- list_current->s.s = (char*)( (void*) list_current
+ sizeof(struct str_list));<br>
+ list_current->s.s = (char*)list_current +
sizeof(struct str_list);<br>
list_current->s.len = avp_value.s.len;<br>
memcpy(list_current->s.s,avp_value.s.s,avp_value.s.len);<br>
<br>
It is for 4.1.<br>
<br>
I have some ongoing work to commit soon on the master branch. if you
confirm it is working fine, I will push this patch as well and
backport to 4.1.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div>On 22/08/14 13:03, Charles Chance
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi All,
<div><br>
</div>
<div>I wonder if some one could help me to diagnose a recurring
issue?</div>
<div><br>
</div>
<div>It happens at random times/intervals and under varying
load. But always, just before the time of crash, I see the
same critical error in log:</div>
<div><br>
</div>
<div><font face="courier new, monospace">CRITICAL: dialog
[dlg_hash.c:841]: log_next_state_dlg(): bogus event 6 in
state 1 for dlg 0xb0632134 [1367:5814] with clid '<a href="mailto:0695dd7a346188dd24e7520e6c01092c@sip.sipcentric.com" target="_blank">0695dd7a346188dd24e7520e6c01092c@sip.sipcentric.com</a>'
and tags 'as77c89620' ''<br>
</font></div>
<div><br>
</div>
<div><br>
</div>
<div>Analysing the core dump reveals:</div>
<div><br>
</div>
<div>
<div><font face="courier new, monospace">Core was generated by
`/usr/sbin/kamailio -P /var/run/kamailio.pid -m 128 -M 4
-u kamailio -g kamailio'.</font></div>
<div><font face="courier new, monospace">Program terminated
with signal 11, Segmentation fault.</font></div>
<div><font face="courier new, monospace">#0 0x081a737c in
parse_uri (buf=0x3a70006e <Address 0x3a70006e out of
bounds>, len=275, uri=0xbfa2fd2c) at
parser/parse_uri.c:389</font></div>
<div><font face="courier new, monospace">389<span style="white-space:pre-wrap"> </span>scheme=buf[0]+(buf[1]<<8)+(buf[2]<<16)+(buf[3]<<24);</font></div>
</div>
<div><br>
</div>
<div><font face="courier new, monospace">(gdb) frame 1</font></div>
<div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">#1 0x008fe5dd in
dialog_publish (state=0x903f37 "Trying", ruri=0xb0b5fd00,
entity=0xb0632188, peer=0xb0632190, callid=0xb0632180,
initiator=1, lifetime=7200, localtag=0x0, remotetag=0x0,
localtarget=0x0, </font></div>
<div><font face="courier new, monospace"> remotetarget=0x0,
do_pubruri_localcheck=1) at dialog_publish.c:275</font></div>
<div><font face="courier new, monospace">275<span style="white-space:pre-wrap"> </span>if
(parse_uri(ruri->s, ruri->len, &ruri_uri) <
0) {</font></div>
</div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">(gdb) p *ruri</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div>
<div><font face="courier new, monospace">$1 = {s =
0x3a70006e <Address 0x3a70006e out of bounds>, len
= 275}</font></div>
</div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">(gdb) up</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div><font face="courier new, monospace">#2 0x008ff277 in
dialog_publish_multi (state=0x903f37 "Trying",
ruris=0xb0b5fd00, entity=0xb0632188, peer=0xb0632190,
callid=0xb0632180, initiator=1, lifetime=7200,
localtag=0x0, remotetag=0x0, </font></div>
<div><font face="courier new, monospace">
localtarget=0x0, remotetarget=0x0,
do_pubruri_localcheck=1) at dialog_publish.c:387</font></div>
<div><font face="courier new, monospace">387<span style="white-space:pre-wrap"> </span>dialog_publish(state,&(ruris->s),entity,peer,callid,initiator,lifetime,localtag,remotetag,localtarget,remotetarget,do_pubruri_localcheck);</font></div>
</div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">(gdb) p *ruris</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div><font face="courier new, monospace">$2 = {s = {s =
0x3a70006e <Address 0x3a70006e out of bounds>, len
= 275}, next = 0x0}</font></div>
</div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">(gdb) up</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div><font face="courier new, monospace">#3 0x0090187a in
__dialog_created (dlg=0xb0632134, type=2,
_params=0x6db064) at pua_dialoginfo.c:470</font></div>
<div><font face="courier new, monospace">470<span style="white-space:pre-wrap"> </span>dialog_publish_multi("Trying",
dlginfo->pubruris_caller, &(dlg->from_uri),
(include_req_uri)?&(dlg->req_uri):&(dlg->to_uri),
&(dlg->callid), 1, dlginfo->lifetime, 0, 0, 0,
0, send_publish_flag==-1?1:0);</font></div>
</div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">(gdb) p
*dlginfo->pubruris_caller<br>
</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div><font face="courier new, monospace">$3 = {s = {s =
0x31590014 <Address 0x31590014 out of bounds>, len
= 275}, next = 0xb0b5fd00}</font></div>
</div>
<div><font face="courier new, monospace"><br>
</font></div>
<div>
<div><font face="courier new, monospace">(gdb) p
*dlginfo->pubruris_caller->next</font></div>
<div><font face="courier new, monospace"><br>
</font></div>
<div><font face="courier new, monospace">$4 = {s = {s =
0x3a70006e <Address 0x3a70006e out of bounds>, len
= 275}, next = 0x0}</font></div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>In config, for pua_dialoginfo we are enabling the option
"use_pubruri_avps" and setting "pubruri_caller_avp" and
"pubruri_callee_avp" accordingly.</div>
<div><br>
</div>
<div>Therefore, in pua_dialoginfo.c it is using get_str_list()
function to set dlginfo->pubruris_caller from the avp.</div>
<div><br>
</div>
<div>Could this be some race condition or something completely
different?</div>
<div><br>
</div>
<div>Thanks in advance,</div>
<div><br>
</div>
<div>Charles</div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
<br>
<font face="Helvetica, Arial, sans-serif"><font><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd. Company registered in
England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt
Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a href="mailto:sr-users@lists.sip-router.org" target="_blank">sr-users@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA</pre>
</div>
<br>_______________________________________________<br>
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list<br>
<a href="mailto:sr-users@lists.sip-router.org" target="_blank">sr-users@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><br>
<br></blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="arial, helvetica, sans-serif"><b><font>Charles Chance</font></b><br><font>Managing Director</font></font><br><div><font face="arial, helvetica, sans-serif"><font><br>
</font></font></div><div><font face="arial, helvetica, sans-serif"><font>t. 0121 285 4400 m. 07932 063 891</font></font></div></div>
</div>
<br>
<font face="Helvetica, Arial, sans-serif"><font size="2"><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd.
Company registered in England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font>