<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hello,<br>
    <br>
    can you send the changes as patch (diff) file?<br>
    <br>
    If you got kamailio from git, then you can do:<br>
    <br>
    git diff > /path/to/file.patch<br>
    <br>
    It is easier to review the changes and be sure we are not
    overwriting a new version of the file.<br>
    <br>
    Cheers,<br>
    Daniel<br>
    <br>
    <div class="moz-cite-prefix">On 19/09/14 12:57, dongwf wrote:<br>
    </div>
    <blockquote
      cite="mid:385906c7.ab4c.1488d8f104d.Coremail.dongwflj@163.com"
      type="cite">
      <div
        style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
        <div>Hi Daniel:<br>
          I added my fixing in attached t_msgbuilder.c, please take a
          review, mainly change in build_uac_req, print_to and
          print_from, thanks!<br>
        </div>
        <br>
        <br>
        <br>
        <br>
        <br>
        At 2014-09-17 04:25:17, "Daniel-Constantin Mierla"
        <a class="moz-txt-link-rfc2396E" href="mailto:miconda@gmail.com"><miconda@gmail.com></a> wrote:<br>
        <blockquote id="isReplyContent" style="PADDING-LEFT: 1ex;
          MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">
          Hello,<br>
          <br>
          your remarks seems legit -- if you send a patch, I will review
          and commit it. Otherwise, open an issue on bugh tracker and
          will be fixed soon. I tested the patch with my scenario, it
          works fine.<br>
          <br>
          Cheers,<br>
          Daniel<br>
          <br>
          <div class="moz-cite-prefix">On 17/09/14 10:06, dongwf wrote:<br>
          </div>
          <blockquote
            cite="mid:27a7fd6f.922f.14882a62456.Coremail.dongwflj@163.com"
            type="cite">
            <div
              style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
              <div>Hi kamailio dev:<br>
                I am writing a module to implement some features, my
                version is 4.1.2, I am not sure if it is a known issue,
                I found:<br>
                1. When I get a INVITE request with from/to like
                from:"display"<a moz-do-not-send="true"
                  class="moz-txt-link-rfc2396E"
                  href="mailto:aaa@sip.com"><aaa@sip.com></a>,
                then I call tm's new_dlg_uas with the sip req, now the
                dlg's rem_uri set as value: "display"<a
                  moz-do-not-send="true" class="moz-txt-link-rfc2396E"
                  href="mailto:aaa@sip.com"><aaa@sip.com></a>;<br>
                2. After that, when I need use the dlg to send BYE with
                tm's req_within with the above saved dlg, the print_to
                function will check the rem_uri's first value if "<"
                or not, now my uri has display name, so the outgoing
                BYE's to header becomes to:<"display"<a
                  moz-do-not-send="true" class="moz-txt-link-rfc2396E"
                  href="mailto:aaa@sip.com"><aaa@sip.com></a>>,
                is it wrong? Should we check the last char in the
                rem_uri as ">"?<br>
                <br>
                The detail code is :<br>
                static inline char* print_to(char* w, dlg_t* dialog,
                struct cell* t)<br>
                {<br>
                    t->to.s = w;<br>
                    t->to.len = TO_LEN + dialog->rem_uri.len +
                CRLF_LEN<br>
                        + ((dialog->rem_uri.s[0]!='<')?2:0);<br>
                <br>
                    memapp(w, TO, TO_LEN);<br>
                <span style="color: rgb(255, 0, 0);">   
                  if(dialog->rem_uri.s[0]!='<') memapp(w, "<",
                  1);<br>
                      memapp(w, dialog->rem_uri.s,
                  dialog->rem_uri.len);<br>
                      if(dialog->rem_uri.s[0]!='<') memapp(w,
                  ">", 1);</span><br>
                ....<br>
              </div>
            </div>
            <br>
            <br>
            <span title="neteasefooter"><span id="netease_mail_footer"></span></span><br>
            <fieldset class="mimeAttachmentHeader"></fieldset>
            <br>
            <pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
          </blockquote>
          <br>
          <pre class="moz-signature" cols="72">-- 
Daniel-Constantin Mierla
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany</pre>
        </blockquote>
      </div>
      <br>
      <br>
      <span title="neteasefooter"><span id="netease_mail_footer"></span></span>
    </blockquote>
    <br>
    <pre class="moz-signature" cols="72">-- 
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany</pre>
  </body>
</html>