<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
trying to count in the config could be a way, but I guess you have
to add some delimiter overhead between contacts.<br>
<br>
Increasing it was a proposal for a lazy solution that can be easily
backported. A proper way can be via dynamic allocation or making the
size configurable via a param.<br>
<br>
The code does check if adding a new contact results in overflow, but
then returns an error and the old used contacts are not considered.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 06/11/14 11:35, Dan Christian Bogos
wrote:<br>
</div>
<blockquote cite="mid:545B4ED8.3060608@gmail.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Hey Daniel,<br>
<br>
Thanks for your fast feedback!<br>
<br>
Not sure what is the best approach on this. We reach the 512 limit
sometimes even with just 2 contacts in one AOR (since we cannot
pass the path in redirect, we use a uri parameter to add it and
process that later in other components, so I guess that is our
sin). I guess we can work with 1024 as well, but on the other
hand, how can I control what goes into that buffer? <br>
<br>
Will counting in the script of the RURIs length in all of the
branches before calling 302 be sufficient to keep the buffer under
it's limits? Would it be not possible for the core to check on
each contact if adding it will not create the buffer overflow
instead of dropping all data in the buffer (returning no contact)
when that happens?<br>
The issue is that it is hard for me as admin to know what will go
into the contact data since that content comes directly from UAs.<br>
<br>
Cheers,<br>
DanB<br>
<br>
<span style="color: rgb(0, 0, 0); font-family: Verdana, Geneva,
Helvetica, Arial, sans-serif; font-size: 13px; font-style:
normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; background-color: rgb(255, 255, 255);">looks like
the overall buffer for contacts in redirect is 512 in size,
perhaps same value from early beginnings. MAX_REDIRECTION_LEN in
config.h needs to be changed to larger value -- should 1024 be
enough?</span><br style="color: rgb(0, 0, 0); font-family:
Verdana, Geneva, Helvetica, Arial, sans-serif; font-size: 13px;
font-style: normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255);">
<br style="color: rgb(0, 0, 0); font-family: Verdana, Geneva,
Helvetica, Arial, sans-serif; font-size: 13px; font-style:
normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255);">
<span style="color: rgb(0, 0, 0); font-family: Verdana, Geneva,
Helvetica, Arial, sans-serif; font-size: 13px; font-style:
normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; background-color: rgb(255, 255, 255);">Cheers,</span><br
style="color: rgb(0, 0, 0); font-family: Verdana, Geneva,
Helvetica, Arial, sans-serif; font-size: 13px; font-style:
normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255);">
<span style="color: rgb(0, 0, 0); font-family: Verdana, Geneva,
Helvetica, Arial, sans-serif; font-size: 13px; font-style:
normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: normal; orphans: auto;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; background-color: rgb(255, 255, 255);">Daniel</span><br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Training, Nov 24-27, Berlin - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a></pre>
</body>
</html>