<div dir="ltr">+1 Daniel.<div><br></div><div>Shane, you are welcome to submit patch as suggested by Daniel. I will have a look at the spec and what we have impl and get back to you as soon as I find a gap.</div><div><br></div><div>cheers</div><div>jason</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 18, 2015 at 1:16 PM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<span class=""><br>
On 17/02/15 22:52, Shane Harrison wrote:<br>
> Hi IMS'ers<br>
><br>
> I am generating CCR's happily from the ims_charging module (adapted to work standalone with standard userloc module) but have a couple of questions around AVP's supported.<br>
><br>
> a) I note that in the 3GPP TS 32.299 V12.7.0 specification that table 7.1.0.1, that it indicates Vendor-Id and Vendor-Specific-Application-Id aren't used. But later in section 7.1.16 it indicates that the Vendor-Id should be 10415 and set inside the Vendor-Specific-Application-Id AVP. Should I assume that the table is wrong ?<br>
> b) The ims_charging_module doesn't seem to put an Auth-Application-Id into the CCR. This is mandatory according to 3GPP and RFC4006. I note that it does appear under the Vendor-Specific-Application-Id - but this doesn't seem right to me?<br>
><br>
> At this stage I am thinking to add the Auth-Application-Id AVP and also the 3GPP Called-Party-Address AVP. To I submit patches to the development list?<br>
><br>
</span>I am not working with IMS that much, therefore I cannot comment on your<br>
remarks about the specks.<br>
<br>
Just jumping in to say that the recommended way to submit a patch is a<br>
pull request via github project:<br>
<br>
- <a href="https://github.com/kamailio/kamailio" target="_blank">https://github.com/kamailio/kamailio</a><br>
<br>
It allows the other developers to review and make comments. Also, it<br>
doesn't get forgotten as it can happen with maling list patches, because<br>
sometime is higher traffic and some developers can be in vacation or<br>
traveling.<br>
<br>
If github is not liked by you for what so ever reason, patching to<br>
mailing list is the alternative.<br>
<br>
Cheers,<br>
Daniel<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Daniel-Constantin Mierla<br>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
Kamailio World Conference, May 27-29, 2015<br>
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a><br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list<br>
<a href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><table border="0" cellspacing="0" cellpadding="0" width="600" style="width:450pt"><tbody><tr><td valign="top" style="padding:0cm"><p></p></td></tr></tbody></table><table width="320px" border="0" cellpadding="0" cellspacing="0" style="font-family:monospace"><tbody><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><strong>Jason Penton</strong></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><strong>Senior Manager: Applications and Services</strong></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Smile Communications Pty (Ltd)</strong></td></tr><tr><td><table cellpadding="0" cellspacing="0" width="100%"><tbody><tr><td width="27%" style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Mobile:</strong></td><td width="73%" style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px">+27 (0) 83 283 7000</td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Skype:</strong></td><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px">jason.barry.penton</td></tr></tbody></table></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a href="mailto:name.surname@smilecoms.com" style="font-family:Arial;color:rgb(117,179,67);text-decoration:none" target="_blank">jason.penton@smilecoms.com</a></td></tr><tr><td style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a href="http://www.smilecoms.com/" style="font-family:Arial;color:rgb(117,179,67)" target="_blank">www.smilecoms.com</a><br><img src="http://196.33.227.129/~smlcoms/sigs/pty/images/smile_signature_07_09.jpg" width="420" height="144"><br></td></tr></tbody></table></div><br></div></div>
</div>
<br>
<span><font color="#888888"><pre>This email is subject to the disclaimer of Smile Communications at <a href="http://www.smilecoms.com/home/email-disclaimer/" target="_blank">http://www.smilecoms.com/home/<WBR>email-disclaimer/</a><a href="http://www.smilecoms.com/disclaimer" target="_blank"></a></pre></font></span>