<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I pushed two patches, as it required a small adjustment to acc
module for this case -- they are now in master, affecting acc and
dialog modules. Testing and feedback whether it works or not is very
appreciated.<br>
<br>
I went a different path, considering the case when the bye is coming
from the wire, two callbacks were executed DLGCB_TERMINATED (when
bye was processed) and DLGCB_TERMINATED_CONFIRMED (when it was a
reply to the bye). Same is done now when the bye is generate
locally, so it should match better on the pattern for callbacks.<br>
<br>
The callback for DLGCB_EXPIRED is for the case when no bye was
involved and seems better to leave it as it is. The flag you just
added can be used in the callbacks to see if it was a dialog timeout
or not (as well as looking if there is a sip request passwd to the
callback function as parameter).<br>
<br>
Thanks for troubleshooting so far and pointing in the code, helped
to identify the issue faster and fix it quickly.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 15/04/15 17:04, Daniel-Constantin
Mierla wrote:<br>
</div>
<blockquote cite="mid:552E7DE0.3090702@gmail.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 15/04/15 16:27, Mickael Marrache
wrote:<br>
</div>
<blockquote cite="mid:262e01d07788$4c648ca0$e52da5e0$@gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Texte de bulles Car";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.pl-pds
{mso-style-name:pl-pds;}
span.pl-c1
{mso-style-name:pl-c1;}
span.pl-cce
{mso-style-name:pl-cce;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.TextedebullesCar
{mso-style-name:"Texte de bulles Car";
mso-style-priority:99;
mso-style-link:"Texte de bulles";
font-family:"Tahoma","sans-serif";
mso-fareast-language:EN-US;}
span.pl-k
{mso-style-name:pl-k;}
span.pl-c
{mso-style-name:pl-c;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">I'm
looking at the dlg_ontimeout function
[dlg_handlers.c:1369] and I understand the code, the
DLGCB_EXPIRED callbacks are not called when the send_bye
parameter is set to 1.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">I'm
looking at the block 1399-1408.</span></p>
</div>
</blockquote>
Indeed, looking quickly at that part of the code, the callback is
not executed when sending BYE requests at dialog timeout. It needs
to be fixed, if none picks it up, I will look at it with the first
chance.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<blockquote cite="mid:262e01d07788$4c648ca0$e52da5e0$@gmail.com"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:FR">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:FR">
Mickael Marrache [<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="mailto:mickaelmarrache@gmail.com">mailto:mickaelmarrache@gmail.com</a>]
<br>
<b>Sent:</b> Wednesday, April 15, 2015 3:53 PM<br>
<b>To:</b> <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a><br>
<b>Subject:</b> RE: No CDR is written when dialog
timeouts<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US">I
also confirm the cdr_on_create() [acc_cdr.c:718] function
is called since I can see the debug statement "dialog '%p'
created!"</span><span style="color:#1F497D">.</span><span
style="font-size:9.0pt;font-family:Consolas;color:#183691;background:white"
lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:FR">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:FR">
Mickael Marrache [<a moz-do-not-send="true"
href="mailto:mickaelmarrache@gmail.com">mailto:mickaelmarrache@gmail.com</a>]
<br>
<b>Sent:</b> Wednesday, April 15, 2015 3:48 PM<br>
<b>To:</b> <a moz-do-not-send="true"
href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a><br>
<b>Subject:</b> No CDR is written when dialog timeouts<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I'm testing the dialog
timeout scenario and I see that no CDR is written.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">This is my
configuration:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">modparam("acc",
"cdr_enable", 1)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">modparam("acc",
"cdr_expired_dlg_enable", 1)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">modparam("acc",
"cdr_start_on_confirmed", 1)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">modparam("acc",
"cdr_log_enable", 0)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">modparam("acc",
"cdr_on_failed", 0)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I can confirm the
cdr_on_expired() [acc_cdr.c:684] function is not called
since I don't see the debug statement "dialog '%p'
expired!\n"</span>.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">(I precise that CDR
generation works fine for regular hangup scenario.)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal">Any idea what can cause the issue?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Mickael <span lang="EN-US"><o:p></o:p></span></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
</body>
</html>