<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
To update the content of the README you have to add to/change the
content of the xml files in doc/ subfolder of the module, then run:<br>
<br>
make modules-readme modules=modules/dialog<br>
<br>
Some more details:<br>
<br>
- <a class="moz-txt-link-freetext" href="http://www.kamailio.org/wiki/devel/module-docbook-readme">http://www.kamailio.org/wiki/devel/module-docbook-readme</a><br>
-
<a class="moz-txt-link-freetext" href="http://www.kamailio.org/wiki/devel/makefile-system#generate_readme_for_modules">http://www.kamailio.org/wiki/devel/makefile-system#generate_readme_for_modules</a><br>
<br>
You need docbook utils and xsl schema packages. If you don't have
them and it is not convenient to install, then just change the xml
files in doc/ and we can regenerate it.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 24/08/15 14:52, jay binks wrote:<br>
</div>
<blockquote
cite="mid:CAO47Hpf+kBiVZkZ9yfPONpcyczoEy9aKxh0cgvfzkdKTaXiu0w@mail.gmail.com"
type="cite">
<div dir="ltr">With that in mind , I have fixed the documentation
and reverted my change in
<div><a moz-do-not-send="true"
href="https://github.com/kamailio/kamailio/pull/295">https://github.com/kamailio/kamailio/pull/295</a><br>
</div>
<div><br>
</div>
<div>I've also added a basic <span style="font-size:13px">db_skip_load
as suggested.</span></div>
<div><span style="font-size:13px">( however is there an easy way
to fix the readme, without manually re-numbering everything
? )</span></div>
<div><br>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 24 August 2015 at 17:10,
Daniel-Constantin Mierla <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:miconda@gmail.com"
target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,<br>
<br>
db_fetch_rows is about setting the value of how many rows
to be loaded at once. 0 is a special value meaning that
this limit is not set and all rows are loaded at once.
db_fetch_rows is common parameter for other modules (e.g.,
usrloc) with same kind of behaviour, so I would not change
the behaviour of db_fetch_rows.<br>
<br>
For what you need, maybe db_mode should get a new value --
this is the parameter that controls the relation with
database. However, if the write modes provided by db_mode
are something that worth combining with the "no-read"
mode, then a new parameter can be added, like
db_skip_load.<br>
<br>
Cheers,<br>
Daniel
<div>
<div class="h5"><br>
<br>
<div>On 24/08/15 02:25, jay binks wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div class="h5">
<div dir="ltr">Further to this, I have created a
pull request that I think should behave better.
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/kamailio/kamailio/pull/295"
target="_blank">https://github.com/kamailio/kamailio/pull/295</a><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 24 August 2015 at
10:06, jay binks <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:jaybinks@gmail.com"
target="_blank">jaybinks@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr">Hey All,<br>
<br>
Im just after someone else thoughts on if
this is a bug.<br>
<br>
After reading : <a moz-do-not-send="true"
href="http://kamailio.org/docs/modules/3.3.x/modules_k/dialog.html#idp148408"
target="_blank">http://kamailio.org/docs/modules/3.3.x/modules_k/dialog.html#idp148408</a><br>
Im lead to understand that setting <i>modparam("dialog",
"db_fetch_rows", 0)</i><br>
should instruct the dialog module to write
dialogs to the DB, but not bother loading
them on startup. This sounds like what I'm
after.<br>
<br>
However ever time I set the value to 0,
dialogs are still loaded from the DB.<br>
<br>
a quick dig in the source takes me to the
function <br>
<br>
select_entire_dialog_table in
dlg_db_handler.c<br>
this chunk of code does not appear to
properly implement " if fetch_num_rows == 0
then do nothing "<br>
<br>
Im after a couple of things from you guys.
<div><br>
</div>
<div>a) validation that my understanding of
what SHOULD happen is correct</div>
<div>b) possibly validating that I'm not
crazy, and this is actually a bug :)<br>
<br>
--<br>
Sincerely<span><font color="#888888"><br>
<br>
Jay<br>
<div> </div>
</font></span></div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div>Sincerely<br>
<br>
Jay</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a moz-do-not-send="true" href="mailto:sr-users@lists.sip-router.org" target="_blank">sr-users@lists.sip-router.org</a>
<a moz-do-not-send="true" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><span class="HOEnZb"><font color="#888888">
</font></span></pre>
<span class="HOEnZb"><font color="#888888"> </font></span></blockquote>
<span class="HOEnZb"><font color="#888888"> <br>
<pre cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Book: SIP Routing With Kamailio - <a moz-do-not-send="true" href="http://www.asipto.com" target="_blank">http://www.asipto.com</a></pre>
</font></span></div>
<br>
_______________________________________________<br>
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users
mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users"
rel="noreferrer" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature">Sincerely<br>
<br>
Jay</div>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Book: SIP Routing With Kamailio - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a></pre>
</body>
</html>