<div dir="ltr">I mention that you wrote the patch because it should be easier for you to understand (or remember) the meaning of the patch.<div><br></div><div>For sure, I will appreciate the backport in 4.3</div><div><br></div><div>Thank you.</div><div><br></div><div>Thibault</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-12-03 12:19 GMT+01:00 Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
I wrote many patches over the time, that's why I asked for the
specific details ... I think I considered the patch too big to just
backport and there was no extensive testing for it. If proved to
work good and not break other things in 4.3, then it can be
backported for the next minor release.<br>
<br>
Cheers,<br>
Daniel<div><div class="h5"><br>
<br>
<div>On 03/12/15 00:14, Thibault Gueslin
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo">Daniel-Constantin
Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>
2015-08-25 15:37:34</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo">de07fe4e78e2b7df59fbdffd74ca655bd77570ba</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo">dialog:
refresh value for contact uri for each re-invite<br>
</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo"><br>
</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo">You
wrote the patch!</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo"><br>
</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo">Regards</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo"><br>
</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo">Thibault</p>
<p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo"><br>
</p>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-02 22:56 GMT+01:00
Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank"></a><a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Can you give the
commit id of the patch pushed to master?<br>
<br>
Cheers,<br>
Daniel
<div>
<div><br>
<br>
<div>On 02/12/15 19:12, Thibault Gueslin wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">I have seen that the patch submitted
on master branch to fix this issue have not been
merged to branch 4.3
<div><br>
</div>
<div>I wil try it.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-02 15:57
GMT+01:00 Thibault Gueslin <span dir="ltr"><<a href="mailto:thibault.gueslin@gmail.com" target="_blank"></a><a href="mailto:thibault.gueslin@gmail.com" target="_blank">thibault.gueslin@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">How can I update the contact
alias within the dialog on receiving the
invite ?
<div>(My client is being NAT in any case)<br>
<div><br>
</div>
<div>Should I use the dbg_var to set the
new alias ?</div>
<span><font color="#888888">
<div><br>
</div>
<div>thibault</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</font></span></div>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-02 9:41
GMT+01:00 Thibault Gueslin <span dir="ltr"><<a href="mailto:thibault.gueslin@gmail.com" target="_blank"></a><a href="mailto:thibault.gueslin@gmail.com" target="_blank">thibault.gueslin@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hello Daniel,
<div><br>
</div>
<div>Have you seen the issue I
reported:</div>
<div><br>
</div>
<div><span>
<div style="font-size:13px">However
I get an issue when one
party is changing
connectivity: it sends an
INVITE to update the
location but the keep alive
is still sent to the
previous location.</div>
<div style="font-size:13px">The
dialog info (kamctl dialog
show) still indicates the
previous location.</div>
<div style="font-size:13px">(It
looks like <a href="https://github.com/kamailio/kamailio/issues/273" target="_blank"></a><a href="https://github.com/kamailio/kamailio/issues/273" target="_blank">https://github.com/kamailio/kamailio/issues/273</a>)</div>
<div style="font-size:13px"><br>
</div>
<div style="font-size:13px">I
am using the dialog module
in memory (no db) so I think
I don't need to look at
"db_update_period" parameter
?</div>
<div style="font-size:13px"><br>
</div>
</span>
<div style="font-size:13px">I
have tried to call dog_manage
in the WITHINDLG route but it
does not change anything.</div>
<span><font color="#888888">
<div style="font-size:13px"><br>
</div>
<div style="font-size:13px">thibault</div>
<div style="font-size:13px"><br>
</div>
<div style="font-size:13px"><br>
</div>
<div style="font-size:13px"><br>
</div>
</font></span></div>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-02
7:16 GMT+01:00
Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank"></a><a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> The
dialog is terminated
when the OPTIONS request
doesn't get any reply,
no matter it is sent via
UDP, TCP or other
transport.<br>
<br>
Cheers,<br>
Daniel
<div>
<div><br>
<br>
<div>On 01/12/15
12:08, Thibault
Gueslin wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Thanks </div>
I don't have set
the dialog
property.
<div><br>
</div>
<div>I will add
these lines on
INVITE
reception.</div>
<div>
<div><br>
</div>
<div>dlg_set_property("ka-src");</div>
<div>dlg_set_property("ka-dst");</div>
<div>dlg_set_property("timeout-noreset");</div>
</div>
<div><br>
</div>
<div>But is it
the proper way
to do it with
TCP connection
?</div>
<div>From the
tran</div>
<div><br>
</div>
<div>regards</div>
<div><br>
</div>
<div>thibault</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-01
11:10
GMT+01:00
Daniel-Constantin
Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank"></a><a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><br>
<br>
On 30/11/15
11:37,
Thibault
Gueslin wrote:<br>
> I would
like to
terminate the
dialog when
one party
disconnects<br>
> without
sending a BYE<br>
> (no more
connctivity,
client
shutdown)<br>
><br>
> I am
using TCP
connection.<br>
><br>
> Should I
terminate the
dialog from
event_route[usrloc:contact-expired]
?<br>
><br>
> I have
tried also to
use SIP OPTION
parameter from
dialog module<br>
>
modparam("dialog",
"ka_timer",
10 )<br>
>
modparam("dialog",
"ka_interval",
30 )<br>
> but
nothing is
sent)<br>
><br>
><br>
</span>Have
you set the
keepalive
property for
the dialog?<br>
<br>
<a href="http://kamailio.org/docs/modules/stable/modules/dialog.html#idp3719336" rel="noreferrer" target="_blank"></a><a href="http://kamailio.org/docs/modules/stable/modules/dialog.html#idp3719336" target="_blank">http://kamailio.org/docs/modules/stable/modules/dialog.html#idp3719336</a><br>
<br>
Cheers,<br>
Daniel<br>
<span><font color="#888888"><br>
--<br>
Daniel-Constantin
Mierla<br>
<a href="http://twitter.com/#%21/miconda" target="_blank"></a><a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a>
- <a href="http://www.linkedin.com/in/miconda" target="_blank"></a><a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
Book: SIP
Routing With
Kamailio - <a href="http://www.asipto.com" target="_blank"></a><a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a><br>
<a href="http://miconda.eu" target="_blank"></a><a href="http://miconda.eu" target="_blank">http://miconda.eu</a><br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Book: SIP Routing With Kamailio - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://miconda.eu" target="_blank">http://miconda.eu</a></pre>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Book: SIP Routing With Kamailio - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://miconda.eu" target="_blank">http://miconda.eu</a></pre>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Book: SIP Routing With Kamailio - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://miconda.eu" target="_blank">http://miconda.eu</a></pre>
</div></div></div>
</blockquote></div><br></div>