<div dir="ltr"><div>Hi.</div><div><br></div>It probably also should be noted, that the current implementation works with a lot of different client implementations (we use Python for Nagios and PHP for Management (both built-in XML-RPC as well as ZendFramework's XML-RPC client)), so it cannot be that wrong.<br><div><br></div><div>Just my $0,02,</div><div>Carsten</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-03-29 10:10 GMT+02:00 Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    Hello,<br>
    <br>
    I haven't originally implemented the rpc interface in Kamailio
    (which we inherited via SER merge in 2008), but I expect to be some
    reason for this behaviour, give the code is like 10 years old by
    now. A fault code is a fault code, and if there was successful
    execution, then there was no fault.<br>
    <br>
    It is why I asked to check the xmlrpc specifications, because they
    must say what should be done in case of a successful execution
    without any data to be returned.<br>
    <br>
    If there is a problem with existing returned xml document, then of
    course needs to be fixed. But adding a fault code when the specs
    don't say that, it is not a fix, but breaking the specs.<br>
    <br>
    Cheers,<br>
    Daniel<br>
    <br>
    <div>On 29/03/16 09:54, ycaner wrote:<br>
    </div>
    <blockquote type="cite">
      
      <font face="Courier New, Courier, monospace">Hello Daniel;<br>
            there is only rpc_send method in rpc module that dont  have
        any code and other parameters. it sends empty xml text. if it
        has parameters like fault function , i think it will be useful.<br>
        <br>
        Cheers.<br>
      </font><br>
      <?xml version="1.0"?><br>
      <methodResponse><br>
          <params><br>
              <param><br>
              <value></value><br>
              </param><br>
          </params><br>
      </methodResponse><br>
      <br>
      <br>
      <div>29.03.2016 10:32 tarihinde
        Daniel-Constantin Mierla-6 [via SIP Router] yazdı:<br>
      </div>
      <blockquote style="border-left:2px solid #cccccc;padding:0 1em" type="cite"> Hello, <br>
        <br>
        is this correct if there was no error? The fault node should be
        in case <br>
        of errors, not success. You should check the xmlrpc specs to be
        sure any <br>
        chance is conform with the requirements there. <br>
        <br>
        Cheers, <br>
        Daniel <br>
        <br>
        On 29/03/16 09:26, ycaner wrote:
        <div><br>
          > hello; <br>
          > i checked the rpc command and yes , you are right there
          isnt . i will add a <br>
          > rpc return code. it will look like if my pr is accepted.
          <br>
          > <br>
          > <?xml version="1.0"?> <br>
          > <methodResponse> <br>
          >     <fault> <br>
          >         <value> <br>
          >             <struct> <br>
          >                 <member> <br>
          >                     <name>faultCode</name> <br>
          >                     <value> <br>
          >                         <int>200</int> <br>
          >                     </value> <br>
          >                 </member> <br>
          >                 <member> <br>
          >                     <name>faultString</name>
          <br>
          >                     <value> <br>
          >                         <string>domain is
          reloaded</string> <br>
          >                     </value> <br>
          >                 </member> <br>
          >             </struct> <br>
          >         </value> <br>
          >     </fault> <br>
          > </methodResponse> <br>
          > <br>
          > <br>
          > <br>
          > -- <br>
          > View this message in context: <a href="http://sip-router.1086192.n5.nabble.com/XML-RPC-reply-doesn-t-contain-any-data-tp146894p146895.html" rel="nofollow" link="external" target="_blank">http://sip-router.1086192.n5.nabble.com/XML-RPC-reply-doesn-t-contain-any-data-tp146894p146895.html</a><br>
          > Sent from the Users mailing list archive at Nabble.com. <br>
          > <br>
          > _______________________________________________ <br>
          > SIP Express Router (SER) and Kamailio (OpenSER) -
          sr-users mailing list <br>
          > <a href="http:///user/SendEmail.jtp?type=node&node=146897&i=0" rel="nofollow" link="external" target="_blank">[hidden email]</a>
          <br>
          > <a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" rel="nofollow" link="external" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a></div>
        <br>
        -- <br>
        Daniel-Constantin Mierla <br>
        <a href="http://www.asipto.com" rel="nofollow" link="external" target="_blank">http://www.asipto.com</a><br>
        <a href="http://twitter.com/#%21/miconda" rel="nofollow" link="external" target="_blank">http://twitter.com/#!/miconda</a> -

        <a href="http://www.linkedin.com/in/miconda" rel="nofollow" link="external" target="_blank">http://www.linkedin.com/in/miconda</a><br>
        Kamailio World Conference, Berlin, May 18-20, 2016 - <a href="http://www.kamailioworld.com" rel="nofollow" link="external" target="_blank"></a><a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a><br>
        <br>
        <br>
        _______________________________________________ <br>
        SIP Express Router (SER) and Kamailio (OpenSER) - sr-users
        mailing list <br>
        <a href="http:///user/SendEmail.jtp?type=node&node=146897&i=1" rel="nofollow" link="external" target="_blank">[hidden email]</a>
        <br>
        <a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" rel="nofollow" link="external" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><br>
        <br>
        <br>
        <hr color="#cccccc" size="1" noshade>
        <div style="color:#444;font:12px tahoma,geneva,helvetica,arial,sans-serif">
          <div style="font-weight:bold">If you reply to this email, your
            message will be added to the discussion below:</div>
          <a href="http://sip-router.1086192.n5.nabble.com/XML-RPC-reply-doesn-t-contain-any-data-tp146894p146897.html" rel="nofollow" link="external" target="_blank">http://sip-router.1086192.n5.nabble.com/XML-RPC-reply-doesn-t-contain-any-data-tp146894p146897.html</a>
        </div>
        <div style="color:#666;font:11px tahoma,geneva,helvetica,arial,sans-serif;margin-top:.4em;line-height:1.5em">
          To unsubscribe from XML-RPC reply doesn't contain any data, <a rel="nofollow" link="external">click here</a>.<br>
          <a href="http://sip-router.1086192.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml" rel="nofollow" style="font:9px serif" link="external" target="_blank">NAML</a> </div>
      </blockquote>
      <br><span class="HOEnZb"><font color="#888888">
      <div>-- <br>
        
        
        <div align="left">
          <div style="width:300px" align="left"> <a href="http://www.netgsm.com.tr" rel="nofollow" link="external" target="_blank"> <img src="http://sip-router.1086192.n5.nabble.com/attachment/146899/0/yasin-imza-2014.jpg" border="0"> </a> </div>
        </div>
      </div>
      <br>
      <hr align="left" width="300">
      View this message in context: <a href="http://sip-router.1086192.n5.nabble.com/XML-RPC-reply-doesn-t-contain-any-data-tp146894p146899.html" target="_blank">Re:
        XML-RPC reply doesn't contain any data</a><br>
      Sent from the <a href="http://sip-router.1086192.n5.nabble.com/Users-f3.html" target="_blank">Users
        mailing list archive</a> at Nabble.com.<br>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
<a href="mailto:sr-users@lists.sip-router.org" target="_blank">sr-users@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
    </font></span></blockquote><span class="HOEnZb"><font color="#888888">
    <br>
    <pre cols="72">-- 
Daniel-Constantin Mierla
<a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, Berlin, May 18-20, 2016 - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a></pre>
  </font></span></div>

<br>_______________________________________________<br>
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list<br>
<a href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users" rel="noreferrer" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Carsten Bock<br>CEO (Geschäftsführer)<br><br>ng-voice GmbH<br>Millerntorplatz 1<br>20359 Hamburg / Germany<br><br><a href="http://www.ng-voice.com" target="_blank">http://www.ng-voice.com</a><br>mailto:<a href="mailto:carsten@ng-voice.com" target="_blank">carsten@ng-voice.com</a><br><br>Office +49 40 5247593-40<br>Fax +49 40 5247593-99<br><br>Sitz der Gesellschaft: Hamburg<br>Registergericht: Amtsgericht Hamburg, HRB 120189<br>Geschäftsführer: Carsten Bock<br>Ust-ID: DE279344284<br><br>Hier finden Sie unsere handelsrechtlichen Pflichtangaben:<br><a href="http://www.ng-voice.com/imprint/" target="_blank">http://www.ng-voice.com/imprint/</a></div>
</div>