<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>On 04/05/16 08:18, Alex Balashov wrote:<br>
</p>
<blockquote cite="mid:5729944C.6010207@evaristesys.com" type="cite">On
05/04/2016 02:09 AM, Daniel-Constantin Mierla wrote:
<br>
<br>
<blockquote type="cite">the new code example doesn't do exactly
like the old one
<br>
</blockquote>
<br>
D'oh! You're right. I was careless in my analysis of that
statement, and didn't see that the negation was on the outside.
<br>
<br>
It sounds like the GRUU-related commit that introduced this was
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/kamailio/kamailio/commit/fd9fe6e683ca3c446daa043035072a379f9b11bb">https://github.com/kamailio/kamailio/commit/fd9fe6e683ca3c446daa043035072a379f9b11bb</a>
<br>
<br>
I don't know who is to blame? ;-)
<br>
</blockquote>
:-) -- knowing that I tend to use clear statements, looking at the
patch the expression was more or less inherited from previous
version, respectively the patch removes:<br>
<meta charset="utf-8">
<br>
- while ( (ptr) &&<br>
- !(VALID_CONTACT(ptr,act_time) && (ret=-2) &&
allowed_method(_m,ptr)))<br>
- ptr = ptr->next;<br>
- if (ptr==0) {<br>
<br>
Cheers,<br>
Daniel<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, Berlin, May 18-20, 2016 - <a class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
</body>
</html>