<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>I expect that sometimes the "end point" functions (not executed
by other C functions, being only available to the config) are
tested only for some specific needs by the developer. Don't recall
the code by heart right now, but I guess these functions should
have worked fine to some extent if the route existed.<br>
</p>
For 5.0 it is planned a better unit testing framework and eventually
new config function addition will come with few tests around it.<br>
<br>
Thanks for reporting the results after the patch, it will be
backported.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 12/05/16 21:36, Alex Balashov wrote:<br>
</div>
<blockquote cite="mid:5734DB20.3060502@evaristesys.com" type="cite">Daniel,
<br>
<br>
I can confirm that this does seem to fix the issues. Thank you
very much for the rapid response and hard work as always!
<br>
<br>
Question: looking at the commit, it would appear as if much of the
function had to be rewritten entirely. The initial commit of this
functionality was made in early 2013:
<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/kamailio/kamailio/commit/c2c4c393a3c68ed3fb6fd53a71febdd93398f77c">https://github.com/kamailio/kamailio/commit/c2c4c393a3c68ed3fb6fd53a71febdd93398f77c</a>
<br>
<br>
Since it clearly did not work _at all_, and was _totally_ broken,
I have to ask: would it be reasonable to conclude that the
committer never tested it at all?
<br>
<br>
-- Alex
<br>
<br>
On 05/12/2016 10:57 AM, Daniel-Constantin Mierla wrote:
<br>
<br>
<blockquote type="cite">Hello,
<br>
<br>
can you try with the commit
6a3fc200b19500ddd6ed9a2236db6e21f777564a
<br>
pushed to master? There were some improper conditions done when
checking
<br>
if the routing block exists. Few other issues related to
returned code
<br>
were fixed.
<br>
<br>
If all is ok, then it can be backported.
<br>
<br>
Cheers,
<br>
Daniel
<br>
<br>
On 12/05/16 10:56, Alex Balashov wrote:
<br>
<blockquote type="cite">Just for fun, I tried upgrading to the
latest 4.4 HEAD (90be8b) and
<br>
the crash behaviour did not change.
<br>
<br>
</blockquote>
<br>
--
<br>
Daniel-Constantin Mierla
<br>
<a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<br>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a>
-http://www.linkedin.com/in/miconda
<br>
Kamailio World Conference, Berlin, May 18-20, 2016
-http://www.kamailioworld.com
<br>
<br>
<br>
<br>
_______________________________________________
<br>
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users
mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:sr-users@lists.sip-router.org">sr-users@lists.sip-router.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users</a>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, Berlin, May 18-20, 2016 - <a class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
</body>
</html>