[sr-dev] Dialog timeout and in-dialog requests

[Daniel-Constantin Mierla]

Hello,

you can look at how keepalive flags are stored and used as example. You can probably extend the function that sets the property for keepalive for this new feature.

Cheers,
Daniel

--
Daniel-Constantin Mierla
http://www.asipto.com

On 6 Jan 2014, at 14:05, Federico Cabiddu <federico.cabiddu at gmail.com> wrote:

> Hi Daniel,
> thanks for the suggestion, I will try to use the internal flags to store it.
> Please found attached the previous patch without reformatting.
> 
> Regards,
> 
> Federico Cabiddu
> 
> 
> On Mon, Jan 6, 2014 at 1:46 PM, Daniel-Constantin Mierla <miconda at gmail.com> wrote:
> Hello,
> 
> since it is about 0|1 state, it can be probably stored as a bit over the dialog internal flags, which is iflags column.
> 
> Also, for the patch, do it without reformatting a lot of code, because it is not easy to track the real chances and review it. If there is lot to reformat, do a separate patch before or after the one that adds new features.
> 
> Cheers,
> Daniel
> 
> 
> On 06/01/14 13:31, Federico Cabiddu wrote:
>> Hi,
>> we are using the dialog module to limit the duration of users' calls.
>> We recently discovered (well, it's stated in the module doc) that each subsequent in-dialog request resets the dialog timeout. I can understand that this behavior can be useful in some cases, but in our is causing the call duration limitation to not work. I prepared a simple patch to introduce a new parameter to make this behavior configurable (per module). I would like to have it configurable per dialog, via means of an AVP,  but this would have implications on the dialog save/restore mechanism and on the db schema, so for the moment I left it simple.
>> 
>> Regards,
>> 
>> Federico Cabiddu
>> 
>> 
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
> 
> -- 
> Daniel-Constantin Mierla - http://www.asipto.com
> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
> 
> 
> <dialog_timeout.patch>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140106/7f09d8b2/attachment.html>