[SR-Users] Accounting only the 2nd branch of missed serial forked call

[Ozren Lapcevic]

Hi,

now I'm using t_flush_flags() after setting the accounting flag in
falure_route and latest updates (I have a new 3.1 clone without depth
parameter and I've made sure your changes are in sources), but it doesn't
solve the case, accounting behavior is still exactly the same as described
in the first mail.

If it is of any help, previously I've tested the same scenario where I was
setting the accounting flag in RELAY and LOCATION routes which were called
from failure route.

Cheers
Ozren

On Mon, Sep 12, 2011 at 9:19 AM, Daniel-Constantin Mierla <miconda at gmail.com
> wrote:

>  Hello,
>
> over the weekend I backported the implementation of t_flush_flags() as well
> as auto-update of transaction flags after branch/failure route. Just pull
> the latest branch 3.1 and you are ready to compile/install.
>
> Let us know if it solves the case.
>
> Cheers,
> Daniel
>
>
> On 9/9/11 2:40 PM, Daniel-Constantin Mierla wrote:
>
> Hello,
>
> when you pulled the GIT branch 3.1, did you use --depth 1, like next?
>
>   git clone --depth 1 git://git.sip-router.org/sip-router kamailio
>
> The you just got the snapshot at that time without the history of the
> commit and probably you did the git clone after I did the commit, a new git
> pull taking newer commit. So try cloning again the latest branch 3.1,
> without --depth 1 parameter.
>
> Cheers,
> Daniel
>
>
> On 9/7/11 2:20 PM, Ozren Lapcevic wrote:
>
> Hi,
>
> I've previously installed kamailio from git branch 3.1. Now, I've manged to
> git cherry-pick your patch, but got "fatal: Could not find
> 83620cb7cd14ee3b509eef72d99337567f53967f" when tried to get t_flush_flags().
> I've double-checked commit and found it here:
> http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commit;h=83620cb7cd14ee3b509eef72d99337567f53967f.
> I don't know why I can't cherry-pick it.
>
> Your patch alone, without t_flush_flags(), doesn't change anything in my
> scenario, there is still no logging of 2nd branch.
>
> Cheers
> Ozren
>
>
> On Wed, Sep 7, 2011 at 1:05 PM, Daniel-Constantin Mierla <
> miconda at gmail.com> wrote:
>
>>  Hello,
>>
>>
>> On 9/7/11 11:25 AM, Ozren Lapcevic wrote:
>>
>> Hi Daniel,
>>
>> thanks for the quick fix and reply.
>>
>> What is the easiest way to try this new patch? I'm running kamailio 3.1.4
>> and there is no t_flush_flags() in tmx module in that version. I suppose I
>> need to install Kamailio Devel from git (
>> http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-devel-from-git)
>> to get t_flush flags() and your patch or is there a workaround to apply them
>> to my 3.1.4 branch?
>>
>>
>>  did you install 3.1.4 from tarball/packages or is it from git branch 3.1?
>> If later, then you can do:
>>
>> git pull origin
>> git cherry-pick -x  83620cb7cd14ee3b509eef72d99337567f53967f
>> git cherry-pick -x  c589ca35b2aa3097a3c9e2a5a050514337300c05
>>
>> then recompile/install. First cherry-pick brings the t_flush_flags, the
>> second auto-update of the flags after branch/failure route.
>>
>> If you installed from packages, then you would need to repackage yourself
>> after patching. The patches are available at commit url, for example:
>>
>>
>>
>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c589ca35b2aa3097a3c9e2a5a050514337300c05
>>
>>  There you find at top of the page a link named 'patch' that you can use
>> with git tools to apply or extract the diff-patch part and apply with patch.
>>
>> Cheers,
>>  Daniel
>>
>>
>> Cheers
>> Ozren
>>
>>
>> On Tue, Sep 6, 2011 at 2:18 PM, Daniel-Constantin Mierla <
>> miconda at gmail.com> wrote:
>>
>>>  Hello,
>>>
>>> can you use t_flush_flags() after setting the accounting flag in
>>> falure_route? Automatic update was missing so far, reported by Alex Hermann
>>> as well. I just did a patch, so if you want to try it, see the commit:
>>>
>>>
>>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c589ca35b2aa3097a3c9e2a5a050514337300c05
>>>
>>> Actually, reporting if all goes fine with this patch, will help in
>>> backporting it to 3.1 branch.
>>>
>>> Thanks,
>>> Daniel
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20110912/1358a057/attachment.htm>